Fix NameError when cancelling clone-session file dialogs - #25
Open
BrennanTM wants to merge 1 commit into
Open
Conversation
Both dialog-cancel checks in _cloneSession referenced an undefined name 'sesFilepath' instead of fromSesFilepath/toSesFilepath, so cancelling either file dialog raised NameError instead of aborting the clone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke — both dialog-cancel checks in
ManageSessionPanel._cloneSessionreferenced an undefinedsesFilepath(should befromSesFilepath/toSesFilepath) → cancelling either dialog raisedNameErrorinstead of aborting.Fix — reference the right variables. No new test (modal-dialog path); confirmed by pyflakes. All other dialog-cancel checks in the panel were already correct.