Remove dead shadowed handler in DigitizeLocationsPanel - #26
Open
BrennanTM wants to merge 1 commit into
Open
Conversation
_onSelectedLocationsChanged was defined twice; the second definition (matching the keys-based sigSelectionChanged signature) silently shadowed the first, so the first was dead code. Note the surviving handler leaves the delete button disabled when only unsampled locations are selected, unlike the dead variant, which enabled deletion for any selection and pluralized the label; whether that behavior should be restored is left as a follow-up question.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke —
DigitizeLocationsPanel._onSelectedLocationsChangedwas defined twice; the second (keys-based, matchingsigSelectionChanged) shadowed the first, leaving it dead.Fix — remove the dead first definition. No behavior change.
Question — the surviving handler keeps the delete button disabled when only unsampled rows are selected; the dead variant enabled deletion for any selection and pluralized to "Delete rows". If that was the intent, I can restore it here or in a follow-up.