Replace accidental str sentinel for RemotePlotterProxy on macOS - #27
Open
BrennanTM wants to merge 1 commit into
Open
Replace accidental str sentinel for RemotePlotterProxy on macOS#27BrennanTM wants to merge 1 commit into
BrennanTM wants to merge 1 commit into
Conversation
type('__None') with a single argument returns the type of the argument,
i.e. str, so any string would satisfy isinstance checks against
RemotePlotterProxy on macOS. Use a dedicated never-instantiated class
instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke — macOS branch of
util/pyvista/__init__.py:RemotePlotterProxy = type('__None'). One-argtype()returns the argument's type, i.e.str, so any string satisfiedisinstance(x, RemotePlotterProxy).Fix — a dedicated never-instantiated sentinel class. Checked all ~30
isinstancesites and the threeis RemotePlotterProxyidentity checks: identical behavior minus the str hazard.Tests —
tests/test_util/test_pyvistaDefaults.py(skipped off-macOS).Adjacent, not fixed here —
RemotePlotterProxyBaseis undefined at runtime on macOS inVisualizedROI.py/SampleMetadataOrientationsLayer.py(guarded import, unguarded use); see #20.