Skip to content

fix: preserve explicit zero order salt #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
korowant wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: preserve explicit zero order salt #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/predict_sdk/order_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,7 @@ def build_order(
raise MissingSignerError()

return Order(
salt=str(data.salt or self._generate_salt()),
salt=str(data.salt if data.salt is not None else self._generate_salt()),
maker=effective_maker,
signer=effective_signer,
taker=data.taker or ZERO_ADDRESS,
Expand Down
16 changes: 16 additions & 0 deletions tests/test_order_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,22 @@ def test_build_order_with_custom_salt(self, builder_with_signer: OrderBuilder):

assert order.salt == "123456789"

def test_build_order_with_zero_salt(self, builder_with_signer: OrderBuilder):
"""Preserve an explicitly provided zero salt."""
order = builder_with_signer.build_order(
"LIMIT",
BuildOrderInput(
side=Side.BUY,
token_id="12345",
maker_amount="1000000000000000000",
taker_amount="2000000000000000000",
fee_rate_bps=100,
salt=0,
),
)

assert order.salt == "0"

def test_build_order_with_expiration(self, builder_with_signer: OrderBuilder):
"""Build order with custom expiration."""
future_date = datetime(2100, 1, 1, tzinfo=timezone.utc)
Expand Down