Include shared Nethernet advertisement schemas - #470
Closed
extremeheat wants to merge 3 commits into
Closed
extremeheat wants to merge 3 commits into
extremeheat wants to merge 3 commits into
Conversation
This was referenced Sep 22, 2026
Member
Author
|
Closing because the schema extraction is no longer needed. Advertisement definitions remain in bedrock-protocol; the server wrapper uses its discovery API directly. No additional data-package release is required for this work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include the shared Nethernet advertisement ProtoDef definitions from PrismarineJS/minecraft-data#1325 in the npm package. Bedrock discovery will consume
minecraft-data/data/bedrock/common/nethernetAdvertisement.jsonthrough the existing packaged data tree.Depends on PrismarineJS/minecraft-data#1325. Update the submodule to that PR's merged commit before merging this PR; publish the data package before switching downstream dependencies back to npm.