Repository navigation
Sync with upstream v1.9.33 (adds OBFUSCATED_SHIPMENT_ID) - #4
Merged
Merged
Conversation
Amazon started returning OBFUSCATED_SHIPMENT_ID in relatedIdentifierName on the Finances 2024-06-19 listTransactions response on 10 September 2026. The enum does not carry it, so StringEnumConverter throws and the whole page fails to deserialize (abuzuhri#955). The value is a short opaque token that accompanies SHIPMENT_ID and never replaces it. It is not in Amazon's published model for this API, as EVENT_GROUP_ID and SAFET_CLAIM_ID before it were not. Verified against a live listTransactions response that previously threw. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…ributor constructor Equals(object) cast its argument to an unrelated type in seven models, so overload resolution bound the call back to Equals(object) itself and the method recursed unconditionally, for any argument including null. That kills the process with an uncatchable StackOverflowException as soon as Json.NET serializes such an instance, because CheckForCircularReference calls Contains on the serialize stack, which invokes Equals on the objects it holds. Affected: ItemContributors, ItemContributorRole, GetFeedsResponseV00, GetReportsResponseV00, GetMessagingActionsForOrderResponseLinks, OrderedQuantityDetails and OrderStatus. GetMessagingActionsForOrderResponseLinks also called itself from the typed Equals overload; it now compares Self and Actions like the other generated models. ItemContributor's constructor discarded both parameters and assigned an empty role instead of the supplied value and role. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
AsinIdentifier and Audience had empty constructor bodies, Money never assigned Amount even though it is documented as required, and OrderAcknowledgementItem dropped vendorProductIdentifier. Callers that build these models through the constructor lost the values without any hint; OrderAcknowledgementItem is a request model, so the identifier was missing from submitAcknowledgement payloads. Deserialization was unaffected, since Json.NET uses the [JsonConstructor] parameterless constructors and the property setters. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…ingEnumValues fix: add missing PRODUCT and LISTING values to IssueCategory enum
…d-shipment-id Add OBFUSCATED_SHIPMENT_ID to RelatedIdentifierNameEnum
…dConstructorInit fix(models): infinite recursion in Equals overrides and constructors dropping their parameters
ProNotion
force-pushed
the
sync/upstream-v1.9.33
branch
from
October 13, 2026 06:28
03c0246 to
3e953ed
Compare
Wraps GET /finances/v0/financialEvents/shipment/{shipmentId} with NextToken
pagination and its own rate limit entry.
Brings in OBFUSCATED_SHIPMENT_ID on RelatedIdentifierNameEnum (upstream abuzuhri#956), missing IssueCategory enum values, model constructor and Equals fixes, and notification speed fixes.
ProNotion
force-pushed
the
sync/upstream-v1.9.33
branch
from
October 13, 2026 06:29
3e953ed to
cae50c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs this branch with upstream/main (v1.9.33).
Why
The v2024-06-19 Finances API now returns
OBFUSCATED_SHIPMENT_IDas a related identifier name. Without it inRelatedIdentifierNameEnum, deserialisingListFinancialTransactionsresponses throws. Upstream abuzuhri#956 adds the value.What's in it
feat(finances): v0 financial events by shipment ID (GET /finances/v0/financialEvents/shipment/{shipmentId}), with NextToken pagination and a rate limit entry.OBFUSCATED_SHIPMENT_ID, missing IssueCategory enum values, model constructor andEqualsrecursion fixes, notification speed fix, AWS SDK bumps.Testing
Built and tested against a consuming application; its unit test suite passes.