Repository navigation
Conversation
GroupService::updateSenderRules() deleted and regenerated the sender rules of all the groups each time a group, a group rule or a user was modified. It now accepts the list of the groups to update. Without argument, it still updates all the groups (used by the LDAP import, the alias import and the agentj:update-group-rules command). When editing a user, both the old and the new groups are updated so the rules of the groups the user has been removed from are deleted. When deleting a group, nothing needs to be done as the rules are deleted by the database (ON DELETE CASCADE). Closes Probesys#691
pierretux
force-pushed
the
fix/691-update-sender-rules-per-group
branch
from
November 6, 2026 11:16
12828c8 to
f4c9af7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Closes #691
GroupService::updateSenderRules()now accepts the list of groups to update, and only thewblistrows of these groups are deleted and regenerated. Without argument, all the groups are still updated (kept for the LDAP import, the aliases CSV import and theagentj:update-group-rulescommand, which are bulk operations).$groupWbUpdatearray)wblist.group_idisON DELETE CASCADEHow to test manually
wblist(SELECT * FROM wblist WHERE group_id IS NOT NULL).datemodof group B rows is unchanged), and the new value is applied.wblist.Reviewer checklist