Skip to content

fix: exclude local agent artifacts from checks - #520

Merged
Producdevity merged 2 commits into
stagingfrom
fix/local-agent-check-exclusions
Nov 9, 2026
Merged

Producdevity merged 2 commits into
stagingfrom
fix/local-agent-check-exclusions

Conversation

@Producdevity

@Producdevity Producdevity commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

Description

Git-ignored .agents diagnostics could still be collected by lint and test commands. Exclude these directories at any depth from ESLint, TypeScript, Vitest and every Playwright project.

No linked issue.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Refactor
  • Other (please describe):

How Has This Been Tested?

  • Local build
  • Lint
  • Typecheck
  • Unit tests
  • Manual testing

Verified root and nested diagnostic fixtures against the real tools. The before/after discovery comparison retains all 212 real unit-test files and 294 browser-test cases, while excluding the nested agent fixtures. Application files remain included by ESLint and TypeScript. Temporary fixtures were removed.

GitHub CI passed on 65ad30a5: lint, types, production build, 2,156 unit tests (four existing skips), and browser tests (291 passed, one navigation test passed on retry, two skipped). The follow-up also passed focused local lint, type checking and the normal pre-commit hook.

Local CPU/GPU component-import timeouts also reproduce on unchanged staging. Local pre-push bypasses were approved for this PR; test assertions and timeout settings are unchanged.

Screenshots (if applicable)

Not applicable.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I have checked that all checks (lint, typecheck, test) pass

Notes for reviewers

Playwright's project-level ignore list overrides its top-level list, so the agent-folder exclusion is included in both. Vitest's default exclusions are preserved. No documentation update is needed for this tooling fix.

Summary by CodeRabbit

  • Chores
    • Updated project validation settings to exclude agent-related files from linting, TypeScript checks, and Playwright tests.
    • Updated unit test settings to retain default exclusions while excluding Playwright configuration and agent-related files.
    • Reformatted an internal route-boundary notice without changing its wording. These changes affect development tooling only; no end-user features or behavior changed.

@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

ESLint, TypeScript, Vitest, and Playwright now exclude .agents files from their checks. Vitest preserves its default exclusions. The ESLint boundary message is split across lines without changing its text.

Changes

Tooling check scope

Layer / File(s) Summary
Static-analysis configuration
eslint.config.mjs, tsconfig.json
The ESLint ignore patterns and TypeScript exclusions now include .agents. The ESLint boundary message is split across lines; its text is unchanged.
Test-runner exclusions
playwright.config.ts, vitest.config.mts
Playwright excludes .agents files at the top level and in its Chromium project. Vitest preserves its default exclusions and adds exclusions for Playwright configuration and .agents files.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Possibly related PRs

  • Producdevity/EmuReady#512: This PR changes which files ESLint, TypeScript, Vitest, and Playwright include in checks used by #512's release gates.
Merge Risk: Minimal · up to 65ad3

No merge-blocking issue was identified. CI should pass before merge.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title clearly summarizes the main change: excluding local agent artifacts from checks.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description check Passed The description is complete. It summarizes the change, identifies the bug fix, reports testing and CI results, and includes reviewer notes. It states that there is no linked issue and explains why no …
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 3 files. (1 skipped: 1 unsupported.)

Full details: Description check

Explanation

The description is complete. It summarizes the change, identifies the bug fix, reports testing and CI results, and includes reviewer notes. It states that there is no linked issue and explains why no documentation update is needed.

Finishing Touches

Generate docstrings

  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 51462fe8-f180-4735-b16e-211ef90fd21b
Commits

Reviewing files that changed from the base of the PR and between f820a7d and 65ad30a.

Files selected for processing: 4

  • eslint.config.mjs
  • playwright.config.ts
  • tsconfig.json
  • vitest.config.mts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

View guided diff | Turn on auto-fix | Re-trigger cubic

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comments: 1

eslint.config.mjs-107-107: 1

107-107: Major · Functional Correctness · Quick win

Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.

Ignore nested .agents directories.

.gitignore Line 79 ignores .agents at any depth, but this pattern only ignores the root directory. If an agent creates src/.agents/scratch.js, eslint . can still parse it and fail. Use **/.agents/** to match the Git ignore rule. (eslint.org)

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Repository UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: e90f0051-c52a-4e83-a3df-7651a3d4d284
Commits

Reviewing files that changed from the base of the PR and between f820a7d and 064d066.

Files selected for processing: 2

  • eslint.config.mjs
  • tsconfig.json

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread tsconfig.json Resolved
@Producdevity
Producdevity merged commit da5e5cf into staging Nov 9, 2026
12 checks passed
@Producdevity
Producdevity deleted the fix/local-agent-check-exclusions branch November 9, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant