Pass flags through HWAccel.create(), and match more type stubs to the runtime - #2416
Merged
Merged
Conversation
create() builds the context it returns from a new HWAccel, and copied every argument but flags, so av_hwdevice_ctx_create() always got 0.
VideoStream.__getattr__ raises AttributeError for framerate and rate on purpose, so the stub let code type-check that failed at runtime. Drop them, along with Buffer.__bytes__ and InputContainer.flush_buffers(), which do not exist from Python either. HWAccel defaults allow_software_fallback to True, not False, and accepts an int device type. ArgumentError is also a ValueError. Add HWAccel.config, FilterContext.filter, Subtitle.type, and VideoCodecContext.reformatter, which the runtime has and the stubs did not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.