Repository navigation
v1 VANTAstar: simulation, VANTAstar(simulation=True) - #1585
Open
niklashoelter wants to merge 3 commits into
Open
niklashoelter wants to merge 3 commits into
niklashoelter wants to merge 3 commits into
Conversation
…configuration - the configuration decodes the fitted hardware from the INIT reply's modules: photomultipliers, temperature controller, pumps, spectrometer, monochromator slides, atmospheric control unit, stirrer, stacker and barcode readers - `driver.save_configuration(path)` writes it, the serial number a placeholder; `declared_configuration_json` makes `setup` refuse a reader that disagrees with it on what is fitted (`FITTED_FIELDS`), as on the CLARIOstar - the tested reader's configuration is kept as a recording (`RECORDING_VANTASTAR`)
- `VANTAstarSimulationDriver`: nothing reaches a wire; the configuration comes from a declared configuration (by default `RECORDING_VANTASTAR`), the drawer, shaker and temperature controller act at once, as on the CLARIOstar - absorbance (endpoint, spectra), fluorescence (endpoint) and luminescence reads check their arguments as a reader's do and return random values, or those of `simulated_data`; a reader's reads take `simulated_data` and ignore it - fluorescence spectra, `adjust_gain_and_focus`, `measure_z_profile` and `estimate_duration` are not simulated
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #1584 (
declared_configuration_json): its commit shows here until that one is merged; the new commit is the last one.The Problem
As requested in #1574: automated protocols with a VANTAstar could not run without the reader. The CLARIOstar has a simulator for this; the VANTAstar did not.
PR Content
VANTAstar(simulation=True), built as the CLARIOstar's simulator:VANTAstarSimulationDriver: nothing reaches a wire. The configuration comes fromdeclared_configuration_json, by default the tested reader's recording (RECORDING_VANTASTAR). Status comes from the simulated state; the drawer, the shaker and the temperature controller act at once (without a target there is no temperature, as on the CLARIOstar).simulated_data: given an earlier result, a simulated read returns its values for the measured wells, checked against the read (wavelengths, optics, wells). A reader's reads takesimulated_datatoo and ignore it.NotImplementedError): fluorescence spectra,adjust_gain_and_focus,measure_z_profile,estimate_duration._build_io(the simulator builds none), and each read's check-and-build step is a helper shared with the simulator.Testing
simulated_data(and the mismatches it refuses), argument checks and the drawer as on a reader, the temperature controller, the shaker, stop with a plate left in, a simulated read inrun_cycles, the methods not simulated.simulated_datareturns what it read.🤖 Generated with Claude Code
https://claude.ai/code/session_01GjS7QqcG9eMHsBzAi58Xf3