Skip to content

Feat: 3D extension to Structure Tensor slope estimation#774

Open
mrava87 wants to merge 8 commits into
PyLops:devfrom
mrava87:feat-st3d
Open

Feat: 3D extension to Structure Tensor slope estimation#774
mrava87 wants to merge 8 commits into
PyLops:devfrom
mrava87:feat-st3d

Conversation

@mrava87

@mrava87 mrava87 commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

This PR extended slope_estimate to 3D inputs.

It also includes some analytical tests both for the 2D and 3D scenario against plane waves with fixed slope/dip.

@mrava87
mrava87 marked this pull request as draft July 19, 2026 22:54
@codacy-production

codacy-production Bot commented Jul 19, 2026

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 4 medium

Alerts:
⚠ 4 issues (≤ 0 issues of at least minor severity)

Results:
4 new issues

Category Results
Complexity 4 medium

View in Codacy

🟢 Metrics 16 complexity · 0 duplication

Metric Results
Complexity 16
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@mrava87
mrava87 requested a review from cako July 21, 2026 21:59
@mrava87
mrava87 marked this pull request as ready for review July 21, 2026 22:00
@mrava87
mrava87 requested review from cako and removed request for cako July 24, 2026 16:41
cako added 2 commits July 26, 2026 11:52
* fix int(None) when using batch_size=None in 3d
* fix unbound gyy when dips=True and anisotropies=False in 3d
* eigh already returns sorted eigs
* early return for dips=True anisos=False
* allocate arrays as lazily as possible
* fix dy dosctring

@cako cako left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few changes, have a look! Otherwise looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants