Fix bug where Python interpreter exit status is consumed by ORBIT_MPI_Finalize hook. Add ORBIT_MPI_Gather/ORBIT_MPI_Allgather - #144
Open
woodtp wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#119 was growing in scope, so I split off the work in
orbit_mpiinto its own PR.ORBIT_MPI_Finalizecalled atPy_AtExitwould not propagate the exit status of the interpreter, and so would always return a successful exit code. This meant that runningpytestwith MPI would always "succeed" even if tests fail.ORBIT_MPI_GatherandORBIT_MPI_Allgathercompatibility shims.