Allow duplicate element names in MAD-X parser - #146
Open
austin-hoover wants to merge 4 commits into
Open
austin-hoover wants to merge 4 commits into
austin-hoover wants to merge 4 commits into
Conversation
Contributor
Author
|
Note: in this case there appears to be an error with the MADX lattice definition: BPM_B02 is repeated when defining the beam line. I'm not sure what the default PyORBIT behavior should be in this case. Should we allow duplicate element names? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MAD-X allows a single element definition to be repeated in a LINE definition. For example:
This will output:
When it is read by
orbit.teapot.TEAPOT_Lattice, the parser ignores the repeated element. See the SNS AR example here:sns-ring-madx.zip
MAD-X tunes are 6.23, 6.16, and lattice length is 248.0098418.
Old output:
New output with the modified parser: