feat: Add spoiler channel flag and functions - #3252
Conversation
|
Thanks for opening this pull request! This pull request can be checked-out with: git fetch origin pull/3252/head:pr-3252
git checkout pr-3252This pull request can be installed with: pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3252/head |
Lulalaby
left a comment
There was a problem hiding this comment.
Can someone request changes reminding me to add editing & creating channels with that flag
and whatever else i may have forgotten
Soheab
left a comment
There was a problem hiding this comment.
Needs a way for bots to create this kind of channel
This message was sponsored by toothyfernsan on discord.
|
I tested it with all but MediaChannels since I don't have access to those anywhere, but I'd still like a second pair of testing eyes on this |
|
Also, creating a channel with this turned on isn't possible unfortunately, gotta create + edit |
# Conflicts: # CHANGELOG.md
Signed-off-by: Lala Sabathil <lala@pycord.dev>
Signed-off-by: Lala Sabathil <lala@pycord.dev>
This comment was marked as resolved.
This comment was marked as resolved.
|
This feature is now documented (https://docs.discord.com/developers/resources/channel#channel-object-channel-flags) and thus ready to merge |
|
The API will autoconvert spoiler channels to NSFW channels, but not NSFW channels to spoiler channels. I assume this is because they want to prevent people from accidentally disabling NSFW on channels. |
Signed-off-by: ToothyDev <55001472+ToothyDev@users.noreply.github.com>
Summary
This adds
ChannelFlags.is_spoiler_channel(following https://docs.discord.food/resources/channel#channel-flags) as well as a.is_spoiler()function to all applicable channel types (all except category).Channel editing with this flag is also functional, although stage channels seem to be special in that they have the options of nsfw and spoiler in the client, but it seems to have no effect. Thus I skipped adding it there for the time being, as
nsfwis also not documented as a valid edit option for stage channels as of now.Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.