Skip to content

Feat/engine v2 - #2883

Draft
rmnbrd wants to merge 6 commits into
stagingfrom
feat/engine-v2
Draft

Feat/engine v2#2883
rmnbrd wants to merge 6 commits into
stagingfrom
feat/engine-v2

Conversation

@rmnbrd

@rmnbrd rmnbrd commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Issue:

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@nx-cloud

nx-cloud Bot commented Aug 19, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.


View your CI Pipeline Execution ↗ for commit a2ebe4b

Command Status Duration Result
nx-cloud record -- yarn nx format:check ❌ Failed 5s View ↗

💡 Dealing with memory or CPU issues? See memory and CPU details with the resource usage add-on ↗.


☁️ Nx Cloud last updated this comment at 2026-08-21 09:17:37 UTC

@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 61.52513% with 222 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.77%. Comparing base (9896e20) to head (6bf6267).

Files with missing lines Patch % Lines
.../platform-configuration/platform-configuration.tsx 0.00% 53 Missing ⚠️
...ster-creation-flow/step-platform/step-platform.tsx 61.53% 8 Missing and 22 partials ⚠️
...n-guide-modal/cluster-installation-guide-modal.tsx 37.03% 4 Missing and 13 partials ⚠️
.../catalog-variable-input/catalog-variable-input.tsx 31.81% 6 Missing and 9 partials ⚠️
...atform-configuration/hooks/use-cluster-operator.ts 0.00% 12 Missing ⚠️
...luster-creation-flow/step-summary/step-summary.tsx 52.17% 5 Missing and 6 partials ⚠️
...platform-configuration/cluster-operator-status.tsx 57.69% 8 Missing and 3 partials ⚠️
...form-configuration/platform-configuration-utils.ts 81.81% 3 Missing and 7 partials ⚠️
...b/platform-configuration/platform-configuration.ts 70.83% 7 Missing ⚠️
...s/use-platform-template-component-configuration.ts 0.00% 7 Missing ⚠️
... and 17 more
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2883      +/-   ##
===========================================
- Coverage    48.16%   47.77%   -0.39%     
===========================================
  Files         1310     1274      -36     
  Lines        28274    27719     -555     
  Branches      8251     8151     -100     
===========================================
- Hits         13618    13244     -374     
+ Misses       12338    12212     -126     
+ Partials      2318     2263      -55     
Flag Coverage Δ
unittests 47.77% <61.52%> (-0.39%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

rmnbrd and others added 5 commits August 21, 2026 10:20
- guard operator queries against the undefined PostHog flag state (modal,
  create/settings platform routes) so flag-off orgs never hit operator
  endpoints and refreshes no longer bounce users off the platform step
- make engine-v2 cluster creation idempotent on retry and redirect to the
  platform step when platform data is missing instead of failing silently
- fix bool cluster-input requirements round-trip and keep requirement
  inputs mounted during preview refreshes (no more focus loss per keystroke)
- keep cleared field values empty instead of resurrecting schema defaults;
  omit cleared markers from resolver and save payloads
- make components without catalog fields openable so requirement-only
  components can be configured
- exclude Stop / Upgrade K8s actions for self-managed clusters
- restore bool-before-allowedValues precedence in CatalogVariableInput
  (blueprint regression) with a non-regression test
- key PlatformConfiguration by cluster and re-seed when the template list
  changes; surface binding fetch errors instead of redirecting
- add Back navigation to step-platform error/empty states
- drop dead validationMode/componentsConfigurable props, use ts-pattern
  for enum mappers, import catalog types directly from util-js

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants