feat(agent-task): rename agentic workflow - #2907
Conversation
|
View your CI Pipeline Execution ↗ for commit f4e5c49
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 issues found across 16 files
Confidence score: 4/5
- In
libs/domains/audit-logs/feature/src/lib/audit-logs/audit-logs.tsx, the target-type badge still showsAgentic workflowwhile the filter menu showsAgent task, creating an inconsistent product name for the same selection — reusegetTargetTypeLabelfor the badge. - The new
getTargetTypeLabelhelper is only wired into the two filter menus, so other audit-log surfaces that render the same API value (e.g., active filters or list views) still showAgentic workflow— apply the helper consistently across those surfaces.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="libs/domains/audit-logs/feature/src/lib/audit-logs/audit-logs.tsx">
<violation number="1" location="libs/domains/audit-logs/feature/src/lib/audit-logs/audit-logs.tsx:144">
P2: When `AGENTIC_WORKFLOW` is selected, this menu shows `Agent task` but the audit-log target-type badge still shows `Agentic workflow`. Reuse `getTargetTypeLabel` for the badge so the filter has one product name.</violation>
</file>
<file name="libs/domains/audit-logs/feature/src/lib/utils/target-type-selection-utils.tsx">
<violation number="1" location="libs/domains/audit-logs/feature/src/lib/utils/target-type-selection-utils.tsx:21">
P2: The new `getTargetTypeLabel` helper is only wired into the two filter menus (audit-logs.tsx and audit-logs-view.tsx). Other audit-log surfaces that render the same API value still show "Agentic workflow": the active-filter badge in filter-section.tsx (`value: upperCaseFirstLetter(queryParams.targetType).split('_').join(' ')` at line 58, and again at line 108 for the target_id badge) and the Target type column in row-event.tsx (`upperCaseFirstLetter(event.target_type ?? '')?.replace(/_/g, ' ')` at line 315). After this change an AGENTIC_WORKFLOW look-up shows "Agent task" in the menu but "Agentic workflow" in the row and in the active-filter chip, so the rename the PR is meant to land is incomplete. Use `getTargetTypeLabel` at every site that formats `target_type`.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
| return { | ||
| value: item, | ||
| name: upperCaseFirstLetter(item).replace(/_/g, ' '), | ||
| name: getTargetTypeLabel(item), |
There was a problem hiding this comment.
P2: When AGENTIC_WORKFLOW is selected, this menu shows Agent task but the audit-log target-type badge still shows Agentic workflow. Reuse getTargetTypeLabel for the badge so the filter has one product name.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At libs/domains/audit-logs/feature/src/lib/audit-logs/audit-logs.tsx, line 144:
<comment>When `AGENTIC_WORKFLOW` is selected, this menu shows `Agent task` but the audit-log target-type badge still shows `Agentic workflow`. Reuse `getTargetTypeLabel` for the badge so the filter has one product name.</comment>
<file context>
@@ -141,7 +141,7 @@ function createTableDataHead(
return {
value: item,
- name: upperCaseFirstLetter(item).replace(/_/g, ' '),
+ name: getTargetTypeLabel(item),
}
}),
</file context>
| OrganizationEventTargetType.TERRAFORM, | ||
| ]) | ||
|
|
||
| export function getTargetTypeLabel(targetType: string) { |
There was a problem hiding this comment.
P2: The new getTargetTypeLabel helper is only wired into the two filter menus (audit-logs.tsx and audit-logs-view.tsx). Other audit-log surfaces that render the same API value still show "Agentic workflow": the active-filter badge in filter-section.tsx (value: upperCaseFirstLetter(queryParams.targetType).split('_').join(' ') at line 58, and again at line 108 for the target_id badge) and the Target type column in row-event.tsx (upperCaseFirstLetter(event.target_type ?? '')?.replace(/_/g, ' ') at line 315). After this change an AGENTIC_WORKFLOW look-up shows "Agent task" in the menu but "Agentic workflow" in the row and in the active-filter chip, so the rename the PR is meant to land is incomplete. Use getTargetTypeLabel at every site that formats target_type.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At libs/domains/audit-logs/feature/src/lib/utils/target-type-selection-utils.tsx, line 21:
<comment>The new `getTargetTypeLabel` helper is only wired into the two filter menus (audit-logs.tsx and audit-logs-view.tsx). Other audit-log surfaces that render the same API value still show "Agentic workflow": the active-filter badge in filter-section.tsx (`value: upperCaseFirstLetter(queryParams.targetType).split('_').join(' ')` at line 58, and again at line 108 for the target_id badge) and the Target type column in row-event.tsx (`upperCaseFirstLetter(event.target_type ?? '')?.replace(/_/g, ' ')` at line 315). After this change an AGENTIC_WORKFLOW look-up shows "Agent task" in the menu but "Agentic workflow" in the row and in the active-filter chip, so the rename the PR is meant to land is incomplete. Use `getTargetTypeLabel` at every site that formats `target_type`.</comment>
<file context>
@@ -17,6 +18,12 @@ const SERVICE_TARGET_TYPES: ReadonlySet<OrganizationEventTargetType> = new Set([
OrganizationEventTargetType.TERRAFORM,
])
+export function getTargetTypeLabel(targetType: string) {
+ return targetType === OrganizationEventTargetType.AGENTIC_WORKFLOW
+ ? 'Agent task'
</file context>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## staging #2907 +/- ##
===========================================
- Coverage 48.46% 44.75% -3.71%
===========================================
Files 1272 496 -776
Lines 27590 13577 -14013
Branches 8114 4171 -3943
===========================================
- Hits 13372 6077 -7295
+ Misses 11952 6420 -5532
+ Partials 2266 1080 -1186
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
No issues found across 20 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more
Re-trigger cubic
|
🎉 This PR is included in version 1.344.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 participants
Summary
Issue: N/A
AGENTIC_WORKFLOWAPI contracts, internal identifiers, routes, and telemetry values unchanged.Screenshots / Recordings
Not included: this PR only updates product copy and does not change layout or behavior.
Testing
PR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-releaseSummary by cubic
Renames the user-facing "Agentic workflow" terminology to "Agent task" across service creation, settings, environment overview, notifications, confirmation copy, document titles, and audit-log filters. Only product copy changes; existing
AGENTIC_WORKFLOWAPI contracts, internal identifiers, routes, and telemetry values remain unchanged.getTargetTypeLabelhelper so theAGENTIC_WORKFLOWAPI type displays as "Agent task" in filters, badges, and event rows, covered by unit tests.Written for commit f4e5c49. Summary will update on new commits.