Skip to content

fix(onboarding): require a use case selection so onboarding.use_cases is never empty - #2908

Merged
jul-dan merged 7 commits into
stagingfrom
feat/onboarding-use-cases-selection
Aug 27, 2026
Merged

fix(onboarding): require a use case selection so onboarding.use_cases is never empty#2908
jul-dan merged 7 commits into
stagingfrom
feat/onboarding-use-cases-selection

Conversation

@jul-dan

@jul-dan jul-dan commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Issue: QOV-2195

  • Some orgs never populated onboarding.use_cases because the "Continue" button on the use-cases step could be clicked with nothing selected, permanently hiding the "Getting started" checklist on the org overview for every member.
  • Made use case selection mandatory (disable "Continue" until at least one is picked).
  • Replaced rde and spec-to-prod use cases with a new migrate-to-qovery one.
  • Switched the cards layout to flex flex-wrap justify-center so an incomplete last row stays centered.

Screenshots / Recordings

Before After
image image

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

Summary by cubic

Requires onboarding users to select at least one use case before continuing, fixing QOV-2195 so the getting-started checklist is no longer permanently hidden by an empty selection.

  • Replaces the rde and spec-to-prod options with a "Migrate to another cloud provider from Heroku, Render or another PaaS" use case.
  • Centers the use case cards when the last row is incomplete.
  • The Continue button is disabled until at least one use case is selected.

Written for commit 62b3790. Summary will update on new commits.

Review in cubic

jul-dan and others added 4 commits August 27, 2026 10:26
Users could skip use case selection entirely, leaving
onboarding.use_cases empty on the created org. This permanently hid
the getting-started checklist on the org overview for every member,
with no way to recover it afterwards.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@nx-cloud

nx-cloud Bot commented Aug 27, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 35b9904

Command Status Duration Result
nx run console:build --parallel=3 --configurati... ✅ Succeeded 56s View ↗
nx affected --target=test --parallel=3 --config... ✅ Succeeded 18s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 2m 24s View ↗
nx-cloud record -- yarn nx format:check ✅ Succeeded 3s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-08-27 09:08:32 UTC

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread libs/domains/onboarding/feature/src/lib/step-use-cases/step-use-cases.tsx Outdated
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@jul-dan jul-dan changed the title Feat/onboarding use cases selection fix(onboarding): require a use case selection so onboarding.use_cases is never empty Aug 27, 2026
jul-dan and others added 2 commits August 27, 2026 10:58
…e-cases.tsx

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 54.12%. Comparing base (eaaeba1) to head (62b3790).

Files with missing lines Patch % Lines
.../feature/src/lib/step-use-cases/step-use-cases.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2908      +/-   ##
===========================================
+ Coverage    48.46%   54.12%   +5.65%     
===========================================
  Files         1272       13    -1259     
  Lines        27590      303   -27287     
  Branches      8114       64    -8050     
===========================================
- Hits         13372      164   -13208     
+ Misses       11952      128   -11824     
+ Partials      2266       11    -2255     
Flag Coverage Δ
unittests 54.12% <0.00%> (+5.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jul-dan
jul-dan merged commit 4064d1c into staging Aug 27, 2026
9 checks passed
@jul-dan
jul-dan deleted the feat/onboarding-use-cases-selection branch August 27, 2026 12:10
@RemiBonnet

Copy link
Copy Markdown
Member

🎉 This PR is included in version 1.344.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants