Skip to content

fix(cluster-logs): remove gap between scroll controls - #2913

Open
TheoGrandin74 wants to merge 1 commit into
stagingfrom
fix/cluster-deployment-logs-buttons
Open

fix(cluster-logs): remove gap between scroll controls#2913
TheoGrandin74 wants to merge 1 commit into
stagingfrom
fix/cluster-deployment-logs-buttons

Conversation

@TheoGrandin74

@TheoGrandin74 TheoGrandin74 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • group the cluster deployment-log scroll controls with zero gap
  • remove the extra margin that separated the joined buttons
  • add a regression test for the control layout

Validation

  • Prettier: passed
  • ESLint: passed
  • Jest: blocked before execution because the local install is missing declared dependency @radix-ui/react-switch

Summary by cubic

Removes the gap between the cluster log scroll up and down buttons so they render as a single joined control instead of two separated buttons.

  • Groups both buttons in a flex container with zero gap.
  • Removes the extra margin that separated the scroll down button.
  • Adds a regression test asserting the scroll controls have no gap.

Written for commit 1e20cda. Summary will update on new commits.

Review in cubic

@nx-cloud

nx-cloud Bot commented Aug 27, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 1e20cda

Command Status Duration Result
nx run console:build --parallel=3 --configurati... ✅ Succeeded 1m 7s View ↗
nx affected --target=test --parallel=3 --config... ✅ Succeeded 2m 57s View ↗
nx affected --target=lint --parallel=3 ✅ Succeeded 2m 34s View ↗
nx-cloud record -- yarn nx format:check ✅ Succeeded 5s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-08-27 15:31:17 UTC

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Tip: cubic could auto-approve low-risk PRs like this, if it thinks it's safe to merge. Learn more

Re-trigger cubic

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.38%. Comparing base (154489f) to head (1e20cda).
⚠️ Report is 2 commits behind head on staging.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2913      +/-   ##
===========================================
+ Coverage    48.52%   49.38%   +0.85%     
===========================================
  Files         1300      831     -469     
  Lines        28045    20866    -7179     
  Branches      8193     6353    -1840     
===========================================
- Hits         13608    10304    -3304     
+ Misses       12140     8784    -3356     
+ Partials      2297     1778     -519     
Flag Coverage Δ
unittests 49.38% <100.00%> (+0.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants