Skip to content

Embed the 9lives interactive demo inline - #30

Merged
Desperado merged 1 commit into
mainfrom
fix/supademo-inline-embed
Oct 11, 2026
Merged

Desperado merged 1 commit into
mainfrom
fix/supademo-inline-embed

Conversation

@Desperado

Copy link
Copy Markdown
Contributor

The feature tour currently opens Supademo in a separate tab. Replace its linked poster with the supplied inline iframe so visitors can navigate the 9lives locator-repair demo directly on the landing page.

Use the embed's 1.67 aspect ratio, 40px vertical padding and 80vh/80svh height limits, with lazy loading, an accessible title, clipboard-write permission and fullscreen support. Keep a separate new-tab fallback link. No popup SDK is required.

Validation: lint, all 18 existing tests, TypeScript/Next production build and git diff --check passed. Embed URL returned HTTP 200. Chrome preview verified the frame rendered and its Next control worked inside the page. Ponytail review of the changed page, connected rendering, CSS and configuration found no issues. Live deployment, mobile layout and all tour steps were not checked.

@vercel

vercel Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
9lives-run Ready Ready Preview Oct 11, 2026 9:46pm UTC

@qualitymaxapp

qualitymaxapp Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

QualityMax Review

Verdict: COMMENT · Confidence: evidence-backed scan

Re-review: Open the QualityMax check and select Re-review after it completes.

Files eligible: 2 · Files reviewed: 2 · Files with findings: 0 · Findings: 0 · Inline cards: 0

Priority findings

priority location finding
— — No blocking findings

Review gates

gate status
AI diff review completed · eligible 2, reviewed 2 · batches reviewed 1 of 1 · LLM · served qwen3.7-plus
SAST completed · eligible 2, reviewed 2 · hybrid · served qwen3.7-plus
Overall review evidence clean
Inline evidence not needed

Important files

file risk note next step
— — No findings —

Review lifecycle

Use the inline cards to inspect evidence and suggested remediation. Re-run the QualityMax review after pushing a fix; unchanged cards are identified by their stable finding marker. Dismiss with a reason through the existing QualityMax/GitHub review feedback flow. 0 prior card(s) are stale/resolved on this head. @qmax Q&A is tracked separately.

Proof legend: VERIFIED independently judged patch · REPRODUCED verified finding · GROUNDED deterministic evidence · MODEL-ONLY model judgment.

QualityMax project results are available in the configured project.

Receipt · commit 585c03385b6b699ea0b3e20a88a72f1b733e2e67 · run 2026-10-11T21:46:54+00:00 · model served qwen3.7-plus · model requested qwen3.7-plus · model review recorded — 157 model output tokens · model source platform_flags.action_model_defaults.pr_review · re-review 2 · proof counts {}

@qualitymaxapp qualitymaxapp Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QualityMax Review — canonical overview updated; no inline findings were created for this review.

@qualitymaxapp

qualitymaxapp Bot commented Oct 11, 2026

Copy link
Copy Markdown

✅ QualityMax Pipeline

Gate Result
🔍 AI diff review ✅ Clean · qwen3.7-plus · completed · 2 eligible / 2 reviewed · qwen3.7-plus
🔍 SAST completed · 2 eligible / 2 reviewed · qwen3.7-plus
🔍 Canonical PR review delivery completed · 0 eligible / 0 reviewed · exact-head review #5485110554 and overview #6114141249 confirmed
🧪 Repo Tests ❌ 0/0 passed (jest)

Powered by QualityMax — AI-Powered Test Automation

@Desperado
Desperado merged commit e8135df into main Oct 11, 2026
9 checks passed
@Desperado
Desperado deleted the fix/supademo-inline-embed branch October 11, 2026 21:51

This branch was successfully deployed

1 active deployment
Preview — 585c0338 Deployed Oct 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant