Skip to content

Allow the inline Supademo demo through the production CSP - #32

Merged
Desperado merged 1 commit into
mainfrom
fix/supademo-frame-policy
Oct 11, 2026
Merged

Desperado merged 1 commit into
mainfrom
fix/supademo-frame-policy

Conversation

@Desperado

@Desperado Desperado commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

The inline Supademo demo renders locally but is blocked on 9lives.run: Vercel's Content-Security-Policy has default-src 'self' and no frame-src, so the external iframe is rejected.

Allow frames from https://app.supademo.com explicitly. Preserve the rest of the existing policy, including frame-ancestors 'none'. Add a regression test connecting the actual iframe URL to the deployed frame policy and checking that other origins remain excluded.

Validation: all 19 tests, lint, Next production build and git diff --check passed. The production CSP header confirmed the failure; Supademo's embed responds with HTTP 200 and no blocking framing header. Ponytail review completed with no findings. Vercel preview deployment succeeded. Its protected page was inaccessible from the browser, so verified the built site through a local server applying the exact Vercel CSP: the header permits the demo origin, and Chrome renders the tour with its annotation and controls. Production verification remains pending merge and deployment.

@vercel

vercel Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
9lives-run Ready Ready Preview Oct 11, 2026 9:57pm UTC

@qualitymaxapp

qualitymaxapp Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

QualityMax Review

Verdict: COMMENT · Confidence: evidence-backed scan

Re-review: Open the QualityMax check and select Re-review after it completes.

Files eligible: 2 · Files reviewed: 2 · Files with findings: 0 · Findings: 0 · Inline cards: 0

Priority findings

priority location finding
— — No blocking findings

Review gates

gate status
AI diff review completed · eligible 2, reviewed 2 · batches reviewed 1 of 1 · LLM · served qwen3.7-plus
SAST completed · eligible 2, reviewed 2 · hybrid
Overall review evidence clean
Inline evidence not needed

Important files

file risk note next step
— — No findings —

Review lifecycle

Use the inline cards to inspect evidence and suggested remediation. Re-run the QualityMax review after pushing a fix; unchanged cards are identified by their stable finding marker. Dismiss with a reason through the existing QualityMax/GitHub review feedback flow. 0 prior card(s) are stale/resolved on this head. @qmax Q&A is tracked separately.

Proof legend: VERIFIED independently judged patch · REPRODUCED verified finding · GROUNDED deterministic evidence · MODEL-ONLY model judgment.

QualityMax project results are available in the configured project.

Receipt · commit 17e7f6187ae262c90b0e0956427aa814c6bfa2d6 · run 2026-10-11T21:57:13+00:00 · model served qwen3.7-plus · model requested qwen3.7-plus · model review recorded — 101 model output tokens · model source platform_flags.action_model_defaults.pr_review · re-review 2 · proof counts {}

@qualitymaxapp qualitymaxapp Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QualityMax Review — canonical overview updated; no inline findings were created for this review.

@qualitymaxapp

qualitymaxapp Bot commented Oct 11, 2026

Copy link
Copy Markdown

✅ QualityMax Pipeline

Gate Result
🔍 AI diff review ✅ Clean · qwen3.7-plus · completed · 2 eligible / 2 reviewed · qwen3.7-plus
🔍 SAST completed · 2 eligible / 2 reviewed
🔍 Canonical PR review delivery completed · 0 eligible / 0 reviewed · exact-head review #5485148092 and overview #6114245014 confirmed
🧪 Repo Tests ❌ 0/0 passed (jest)

Powered by QualityMax — AI-Powered Test Automation

@Desperado
Desperado merged commit e4d08c8 into main Oct 11, 2026
9 checks passed
@Desperado
Desperado deleted the fix/supademo-frame-policy branch October 11, 2026 22:00

This branch was successfully deployed

1 active deployment
Preview — 17e7f618 Deployed Oct 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant