Skip to content

ci: drop redundant Go module cache step #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Desperado merged 1 commit into from
Sep 8, 2026
Merged

ci: drop redundant Go module cache step #194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions .github/workflows/qamax-go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,6 @@ jobs:
go-version-file: go.mod

@qualitymaxapp qualitymaxapp Bot Sep 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3 · logic · MODEL-ONLY

Removal of the Go module cache step will cause every CI run to re-download all dependencies, increasing build latency and network egress costs.

Evidence: .github/workflows/qamax-go.yml:33
Impact / next step: If the cache was causing issues, consider debugging the cache key or path rather than removing it entirely. If removal is intentional, ensure the team is aware of the resulting increase in CI execution time.

Detailed reasoning
  • Root cause: Removal of the Go module cache step will cause every CI run to re-download all dependencies, increasing build latency and network egress costs.
  • Threat model: Review callers that can reach .github/workflows/qamax-go.yml:33.
  • Existing protection: Reported by llm; confidence: high.
  • Alternatives considered: Preserve the current interface; prefer the smallest safe change.
  • Severity calibration: P3 based on the scanner severity.
Prompt to fix with AI 
Fix this logic finding in .github/workflows/qamax-go.yml:33. Evidence: Removal of the Go module cache step will cause every CI run to re-download all dependencies, increasing build latency and network egress costs. Requested outcome: If the cache was causing issues, consider debugging the cache key or path rather than removing it entirely. If removal is intentional, ensure the team is aware of the resulting increase in CI execution time.. Preserve existing behavior and add focused coverage.

QualityMax · proof: MODEL-ONLY · served model: gemini-3.1-flash-lite · requested: gemini-3.1-flash-lite

check-latest: true

- name: Cache Go modules
uses: actions/cache@v4
with:
path: |
~/.cache/go-build
~/go/pkg/mod
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
restore-keys: |
${{ runner.os }}-go-

- name: Download modules
run: go mod download

Expand Down
Loading