Skip to content

Say payouts go out within a week - #660

Merged
n13 merged 2 commits into
mainfrom
n13/payout-wording
Sep 18, 2026
Merged

n13 merged 2 commits into
mainfrom
n13/payout-wording

Conversation

@n13

@n13 n13 commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

What

Payout timing copy in the mining rewards flow no longer promises Mondays.

  • Confirm page: PAYOUT row reads "Within a week".
  • Submitted page: "Payouts go out within a week. Nothing else to do."
  • Already-claimed page: the row is now labelled "Payout" (same string as the confirm page) with "Within a week"; the separate "Next Payout" string is gone.

Widget tests updated; analyzer clean.

@n13 n13 added the bot-review Request automated review from review-bot label Sep 18, 2026

@n13 n13 left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer model: GPT 5.6 Sol

Verdict (advisory): Approve

No blocking findings. The timing-copy change is consistent across the confirm, submitted, and already-claimed views; the removed Monday-specific localization symbols have no remaining references, and regenerating localizations reproduces the committed output.

Validation:

  • git diff --check 11720aa7...f06bee3d — passed.
  • flutter gen-l10n plus a generated-file diff check — passed.
  • Changed-file dart format --output=none --set-exit-if-changed — passed (7 files, 0 changes).
  • flutter test test/unit/mining_rewards_confirm_screen_test.dart test/unit/mining_rewards_wallet_screen_test.dart — passed (7 tests).
  • Repository-wide analysis was stopped at the required 10-second cap; cold-wallet, miner, and SDK analysis completed cleanly before the cap, while mobile-app analysis had started but not completed. The exact-head GitHub Analyze check is successful.

@n13 n13 removed the bot-review Request automated review from review-bot label Sep 18, 2026

@dewabisma dewabisma left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@n13
n13 merged commit e398fc3 into main Sep 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants