Skip to content

feat: remove note below form - #61

Merged
dewabisma merged 1 commit into
mainfrom
beast/remove-subtext-form
Sep 17, 2026
Merged

dewabisma merged 1 commit into
mainfrom
beast/remove-subtext-form

Conversation

@dewabisma

Copy link
Copy Markdown
Collaborator

No description provided.

@dewabisma
dewabisma requested a review from n13 September 17, 2026 14:08

@n13 n13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer model: GPT 5.6 Sol

Verdict: APPROVE — the note removal is complete and consistent, with no blocking findings.

The optional note prop, conditional markup, responsive styles, only call-site use, and launch.signup.micro translations are removed coherently. Both remaining SignupForm call sites compile, and all nine locale schemas remain aligned.

Validation:

  • npm run format:check — passed.
  • SITE_BASE_URL=http://localhost:3000 npm run build — passed; the build emitted existing unrelated missing-translation warnings and a non-fatal compressor message.
  • Targeted locale-key and built-output checks — passed.
  • git diff --check 2f8c97e...76c87d4 — passed.
  • npm run check:seo-meta — reported 17 pre-existing launch metadata length issues unrelated to this diff.

@dewabisma
dewabisma merged commit 88d5a7d into main Sep 17, 2026
@dewabisma
dewabisma deleted the beast/remove-subtext-form branch September 17, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants