fix: remove obsolete noswissmap GOEXPERIMENT override - #4
Open
ping-ke wants to merge 1 commit into
Open
Conversation
|
Does this mean that before this change, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the unconditional
GOEXPERIMENT=noswissmapoverride from the Go build and test workflow.Problem
The project declares Go 1.21 compatibility, but its build scripts always set:
Go versions that do not recognize the
swissmapexperiment fail before building:The override was added as a temporary workaround for a Go 1.24 conflict involving an external dependency. That dependency has since been removed, so the workaround is no longer needed.
Changes
GOEXPERIMENT=noswissmapexport fromMakefile.go buildandgo vetnormally frombuild.sh.go testnormally from the Makefile and test runner.Behavior Changes
Go build and test commands now use the selected Go toolchain's default experiment settings. This restores compatibility with the Go version declared in
go.modand avoids theunknown GOEXPERIMENT swissmapfailure.No Go source code, dependencies, or public APIs are changed.
Validation