Skip to content

Indonesia sizes its waste from its own IPCC row, not South-Eastern Asia's - #76

Merged
HughRunyan merged 2 commits into
mainfrom
indonesia-sizes-waste-from-its-own-ipcc-row
Oct 12, 2026
Merged

HughRunyan merged 2 commits into
mainfrom
indonesia-sizes-waste-from-its-own-ipcc-row

Conversation

@HughRunyan

Copy link
Copy Markdown
Collaborator

What changes

defaults_2019.msw_per_capita_country gets the row it was missing: Indonesia, 0.19 t/person/yr. Indonesia used to fall back to the South-Eastern Asia regional default, 0.46. That is 2.4× its own row.

The table is a copy of IPCC 2019 Refinement, Vol. 5 Ch. 2, Table 2A.1 (Updated), 2010 column, in tonnes per person per year. I checked all 167 rows against the published PDF and every one matches. Indonesia sits between Brunei and Lao PDR in the IPCC's table and was never typed in. The IPCC's own source for that row agrees: What a Waste 2012 gives 0.52 kg/person/day, and 0.52 × 0.365 = 0.19. The PR also adds one-line comments naming the source tables for msw_per_capita_defaults and msw_per_capita_country, which had none.

Bug report

  • Environment: SWEET_python main at d5c592e. The bug is in SWEET_python/defaults_2019.py, read by City.dst_baseline_blank (WasteMAP's Custom Location) and by City.load_andre_params (the cities-table pipeline, for a city with no waste figure).
  • Reproduce:
    from SWEET_python.city_params import City
    c = City("x"); c.dst_baseline_blank("Indonesia", 1_000_000, 2000.0, 27.0)
    c.baseline_parameters.waste_mass.iloc[0]
  • Expected: 190,000 t/yr, from Indonesia's IPCC row.
  • Actual: 460,000 t/yr, from the South-Eastern Asia default.

Effect (model-output change)

Where Before After
Custom Location, Indonesia, waste mass per million people 460,000 t/yr 190,000 t/yr (−58.7%)
Custom Location, Indonesia, 2M people, CH₄ in 2040, with #74 applied 31,287 t 12,923 t (−58.7%)
Custom Location, Indonesia, CH₄, on main today 0 0 (the zero disposal split that #74 fixes)
WasteMAP's published cities table (June 2026) – No change. All 11 Indonesian cities have their own waste figures, and none of the 39 cities that use a per-capita default is in Indonesia.
Climate TRACE pipeline – No change. Sites with no tonnage are dropped before SWEET runs, and SWEET's site fallback multiplies by a placeholder population of 100.

Cambodia and Timor-Leste are not in the IPCC table, so they keep the regional default. A test covers that.

Not in this PR

Several IPCC rows are themselves implausible (Sri Lanka 1.86 t/yr = 5.10 kg/day; Kuwait 3.05 = 8.36 kg/day; others are far too low, e.g. Ghana 0.03 and Uruguay 0.04). They are faithful copies of the IPCC table, so this is not a transcription error. Which source to use instead is a methodology decision, being raised separately.

Acceptance criteria

  • msw_per_capita_country["IDN"] equals 0.19 t/person/yr, in kg/person/day.
  • Every South-Eastern Asian country in IPCC Table 2A.1 has a row with the IPCC's value.
  • A Custom Location in Indonesia is sized at 0.19 t per person per year.
  • A country the IPCC does not list (Cambodia) still takes its regional default.
  • Changelog entry in changelog/2026-10.md.

Definition of Done

🤖 Generated with Claude Code

msw_per_capita_country is IPCC 2019 Refinement Vol. 5 Ch. 2 Table 2A.1
(Updated), 2010 column. All 167 of its rows match the IPCC's, but Indonesia's
(0.19 t/person/yr) was never typed in, so Indonesia fell back to the
South-Eastern Asia default, 0.46: 2.4x its own row. Adds the row and cites the
source tables in comments.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@HughRunyan HughRunyan added bug Something isn't working model-output-change Changes model OUTPUT values (expected progress, not breaking); results differ from prior runs test Adds or modifies tests labels Oct 9, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@HughRunyan
HughRunyan merged commit 4f01f36 into main Oct 12, 2026
2 checks passed
@HughRunyan
HughRunyan deleted the indonesia-sizes-waste-from-its-own-ipcc-row branch October 12, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working model-output-change Changes model OUTPUT values (expected progress, not breaking); results differ from prior runs test Adds or modifies tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant