Repository navigation
Indonesia sizes its waste from its own IPCC row, not South-Eastern Asia's - #76
Merged
Merged
Conversation
msw_per_capita_country is IPCC 2019 Refinement Vol. 5 Ch. 2 Table 2A.1 (Updated), 2010 column. All 167 of its rows match the IPCC's, but Indonesia's (0.19 t/person/yr) was never typed in, so Indonesia fell back to the South-Eastern Asia default, 0.46: 2.4x its own row. Adds the row and cites the source tables in comments. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
defaults_2019.msw_per_capita_countrygets the row it was missing: Indonesia, 0.19 t/person/yr. Indonesia used to fall back to the South-Eastern Asia regional default, 0.46. That is 2.4× its own row.The table is a copy of IPCC 2019 Refinement, Vol. 5 Ch. 2, Table 2A.1 (Updated), 2010 column, in tonnes per person per year. I checked all 167 rows against the published PDF and every one matches. Indonesia sits between Brunei and Lao PDR in the IPCC's table and was never typed in. The IPCC's own source for that row agrees: What a Waste 2012 gives 0.52 kg/person/day, and 0.52 × 0.365 = 0.19. The PR also adds one-line comments naming the source tables for
msw_per_capita_defaultsandmsw_per_capita_country, which had none.Bug report
mainat d5c592e. The bug is inSWEET_python/defaults_2019.py, read byCity.dst_baseline_blank(WasteMAP's Custom Location) and byCity.load_andre_params(the cities-table pipeline, for a city with no waste figure).Effect (model-output change)
maintodayCambodia and Timor-Leste are not in the IPCC table, so they keep the regional default. A test covers that.
Not in this PR
Several IPCC rows are themselves implausible (Sri Lanka 1.86 t/yr = 5.10 kg/day; Kuwait 3.05 = 8.36 kg/day; others are far too low, e.g. Ghana 0.03 and Uruguay 0.04). They are faithful copies of the IPCC table, so this is not a transcription error. Which source to use instead is a methodology decision, being raised separately.
Acceptance criteria
msw_per_capita_country["IDN"]equals 0.19 t/person/yr, in kg/person/day.changelog/2026-10.md.Definition of Done
🤖 Generated with Claude Code