Repository navigation
Add ecRad test suite - #2637
Open
matthias-ibach wants to merge 1 commit into
Open
Add ecRad test suite#2637matthias-ibach wants to merge 1 commit into
matthias-ibach wants to merge 1 commit into
Conversation
Add ecRad (ECMWF radiation scheme, OpenMP offload) to the test suite: - manifests: add ecrad (master-omp) - build_supp.sh: add netcdf-c, netcdf-fortran, ecbuild and fiat (serial) - run_ecrad.sh: build ecRad, run the CTest suite and the benchmark with comparison against reference
matthias-ibach
requested review from
carlobertolli,
estewart08,
gregrodgers,
ronlieb and
zGoldthorpe
as code owners
October 21, 2026 09:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add ecRad (ECMWF atmospheric radiation scheme) to the test suite. It is a Fortran OpenMP offload app.
Technical Details
manifests/test_24.0.xml: added ecrad (branch master-omp).bin/build_supp.sh: added netcdf-c 4.10.0, netcdf-fortran 4.6.2 (on top of the existing hdf5), ecbuild 3.16.0 (ECMWF CMake macros) and fiat 2.0.1 (ECMWF Fortran library, no MPI. Both are also needed by other ECMWF apps like ecTrans).bin/run_ecrad.sh: Builds ecRad, thenrun_ecrad_testsruns 1) "ecrad" (the CTest suite) and 2) "ecrad-benchmark" (bit-identity check against a reference. Can be skipped with ECRAD_BENCHMARK=OFF). Benchmark data directoy (input, reference, namelist) are not in this repo. If not found on the cluster (/path/to/ecrad-data), feel free to reach out to me.Test Plan
Tested from scratch on ringo and r14 with the srock nightly from 2026-10-19 and the cmake from the nightly (3.31.0):
Test Result
The code has been successfully cloned, build and the test suite has been executed.
Submission Checklist