Repository navigation
[CK_TILE] Fix incompatible vector type arguments for the intrinsic calls - #3672
Merged
Merged
Conversation
poyenc
requested review from
Snektron,
ThomasNing,
afagaj,
andriy-ca,
aosewski,
asleepzzz,
bartekxk,
carlushuang,
cgmillette,
coderfeli,
geyyer,
illsilin,
qianfengz,
shumway,
tenpercent,
vidyasagar-amd and
vpietila-amd
as code owners
January 28, 2026 17:42
poyenc
changed the title
illsilin
previously approved these changes
Jan 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes compilation errors caused by incompatible vector type arguments (specifically signed/unsigned mismatches) in AMD GPU intrinsic function calls. The staging compiler was rejecting these type mismatches.
Changes:
- Added explicit type conversions using
bit_cast<ext_vector_t<short, kABKPerLane>>()for input vectors to AMD MFMA intrinsics - Applied fixes consistently across multiple MFMA operation variants (M32N32K8, M16N16K16, M4N64K4, M64N4K4)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
poyenc
changed the title
illsilin
approved these changes
Jan 30, 2026
poyenc
added a commit
to poyenc/composable_kernel
that referenced
this pull request
Feb 23, 2026
…lls (ROCm#3672) * Change call to the intrinsics * fix clang format * Undo changes under include/ck/utility * Use named variable as vector size --------- Co-authored-by: illsilin_amdeng <Illia.Silin@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix incompatible vector type conversions (mainly signed <-> unsigned) compilation errors that reported by staging compiler.
Checklist
clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered