Conversation
Signed-off-by: 1fanwang <1fannnw@gmail.com>
Member
|
Thank you for the PR. I will try to take a look this week hopefully. Sorry for the delay and thanks for the patience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Building a bootc or container image fails when the build host has no loaded
amdgpudriver, even if the image will run on a GPU host. Both package formats stop withError: AMD GPU driver (amdgpu) is not installed or loaded.Image builds can now install the toolkit without a loaded driver. GPU access still requires the driver on the deployed host.
Closes #141.
Technical Details
Remove the install-time driver checks from RPM and Debian packages. Runtime driver checks and the existing best-effort GPU Tracker initialization remain unchanged. The package-install regression runs in CI for both distributions.
Test Plan
I built and installed the actual packages in GPU-free Linux/amd64 containers: AlmaLinux 9.8 with RPM 4.16.1.3, and Ubuntu 24.04 with dpkg 1.22.6. The binaries were built with Go 1.26.2 on macOS/arm64.
bash /package-install.sh rpmbash /package-install.sh debamd-ctk gpu listamdgpu driver unavailableThe commands below ran from this PR's checkout. They use the same regression script against upstream main, v1.3.0, and this commit.
Raw logs
Upstream main, RPM:
Debian on both upstream main and v1.3.0:
RPM on v1.3.0:
After, RPM:
Docker runtime configuration after installation:
After, Debian:
Both fixed-package runs finish with the expected GPU-discovery error and a successful regression exit:
Test Result
Package installation and Docker configuration succeed without a GPU. GPU discovery still requires the driver, and the existing post-install GPU Tracker warning remains non-fatal. This verifies image construction and configuration, not AMD GPU execution.
Submission Checklist