Repository navigation
[release/2.15] Update the apex related commit for the C++20 fix - #3857
Merged
Merged
Conversation
Move ROCm/apex release/1.15.0 from 3310832c to 11867be7, the release/1.15.0 backport of ROCm/apex#341, which lets PyTorch choose the C++ standard when building apex ops (PyTorch 2.14+ requires C++20). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Author
|
Passing Build Link: https://github.com/ROCm/TheRock/actions/runs/40002541100 |
leconcio
marked this pull request as ready for review
October 23, 2026 18:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
related_commitsfor the 2.15 release.ROCm/apexrelease/1.15.0from3310832cto11867be7, therelease/1.15.0backport of ROCm/apex#341. It is the only commit between the two.-std=c++17from apex'sop_builder/builder.py, so PyTorch'scpp_extensionpicks the C++ standard. PyTorch 2.14+ headers require C++20, so with the old pin the apex ops (amp_C,fused_layer_norm_cuda, ...) fail to build, both when prebuilt and when JIT-compiled on first use.related_commitsare unchanged.Apex release commit: 11867be79cb16fe53bd8b1b898ea38b7508721ff
Test plan
🤖 Generated with Claude Code