Repository navigation
[CK] Work around staging compiler lifetime warning - #4419
Merged
illsilin merged 3 commits intoFeb 12, 2026
Merged
Conversation
The staging compiler enabled lifetime-safety warnings and we already worked around a few of them. This works around a few more instances that came up recently.
illsilin
approved these changes
Feb 10, 2026
illsilin
enabled auto-merge (squash)
February 10, 2026 18:17
Contributor
Author
|
Are the failures related to my changes / flake? |
Contributor
no, i think the ci failures are not related to your changes. we currently have some flaky/broken tests in develop, cause our testing script was broken for a few days and some errors crept in. |
illsilin
deleted the
amd/dev/janplehr/ck/workaround-compiler-lifetime-warnings
branch
February 12, 2026 22:11
assistant-librarian Bot
pushed a commit
to ROCm/composable_kernel
that referenced
this pull request
Feb 12, 2026
[CK] Work around staging compiler lifetime warning ## Motivation The staging compiler enables lifetime-safety warnings and we already worked around a few of them. This works around a few more instances that came up recently on gfx950 builds. The initial PR that resolved most issues: #3640 ## Technical Details This follows the pattern to locally ignore the newly added lifetime-safety warnings that were moved from experimental to production in upstream LLVM. As a result, CK turned them on and treats them as errors, which prevents the staging compiler from building CK. ## Test Plan ## Test Result ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. Co-authored-by: Illia Silin <98187287+illsilin@users.noreply.github.com>
kamuruga08
pushed a commit
that referenced
this pull request
Feb 19, 2026
## Motivation The staging compiler enables lifetime-safety warnings and we already worked around a few of them. This works around a few more instances that came up recently on gfx950 builds. The initial PR that resolved most issues: ROCm/composable_kernel#3640 ## Technical Details This follows the pattern to locally ignore the newly added lifetime-safety warnings that were moved from experimental to production in upstream LLVM. As a result, CK turned them on and treats them as errors, which prevents the staging compiler from building CK. ## Test Plan ## Test Result ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. Co-authored-by: Illia Silin <98187287+illsilin@users.noreply.github.com>
kamuruga08
pushed a commit
that referenced
this pull request
Feb 19, 2026
## Motivation The staging compiler enables lifetime-safety warnings and we already worked around a few of them. This works around a few more instances that came up recently on gfx950 builds. The initial PR that resolved most issues: ROCm/composable_kernel#3640 ## Technical Details This follows the pattern to locally ignore the newly added lifetime-safety warnings that were moved from experimental to production in upstream LLVM. As a result, CK turned them on and treats them as errors, which prevents the staging compiler from building CK. ## Test Plan ## Test Result ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. Co-authored-by: Illia Silin <98187287+illsilin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The staging compiler enables lifetime-safety warnings and we already worked around a few of them.
This works around a few more instances that came up recently on gfx950 builds.
The initial PR that resolved most issues: ROCm/composable_kernel#3640
Technical Details
This follows the pattern to locally ignore the newly added lifetime-safety warnings that were moved from experimental to production in upstream LLVM.
As a result, CK turned them on and treats them as errors, which prevents the staging compiler from building CK.
Test Plan
Test Result
Submission Checklist