Skip to content

Add A4W16 GPT OSS MoE routing for gfx1250 - #1325

Closed
JadenMathias wants to merge 776 commits into
jpvillam/gfx1250_perf1from
jm/oai-oss-path
Closed

JadenMathias wants to merge 776 commits into
jpvillam/gfx1250_perf1from
jm/oai-oss-path

Conversation

@JadenMathias

@JadenMathias JadenMathias commented Sep 23, 2026 •

Copy link
Copy Markdown

Enables the correct preshuffling for A4W16 moe on gfx1250

gpt-oss-120b on gfx1250 — vLLM + aiter fix validation

Tested 2026-09-23/24 in a fresh container (jm-test) from rocm/vllm-dev:nightly_455_wip,
with the image's vLLM and aiter wheels uninstalled and rebuilt from the fix branches.

Environment

component version
GPU gfx1250 (AMD Eng Sample 100-000001046-04), single GPU, TP=1
host kernel / amdgpu Linux 6.14.0-37-generic / 7.1.1.31300009
image rocm/vllm-dev:nightly_455_wip (ubuntu:24.04, Python 3.12)
ROCm SDK 10.1.0a20260822 (rocm-sdk-core/devel/libraries/device-gfx1250, from https://rocm.nightlies.amd.com/whl-multi-arch/)
torch 2.11.0+rocm10.1.0a20260822 (HIP 7.16.26332)
triton 3.8.0+git78420176
vLLM ROCm/vllm branch jm/oai-oss-path @ fd0f802a ("Add A4W16 routing for gfx1250"), python setup.py develop --no-deps
aiter ROCm/aiter branch jm/1250-tdm-gemm-fix @ 78ee6783 ("Fix gfx1250 TDM grouped GEMM bias index missing the N-tile offset"), AITER_USE_SYSTEM_TRITON=1 GPU_ARCHS=gfx1250 python3 setup.py develop --no-deps
lm_eval 0.4.13

Note: the image has no Rust compiler, so setup.py develop silently skips vLLM's Rust
extensions (vllm._rust_tool_parser). Only --tool-call-parser needs them; MiniMax was
therefore run with the smoke test recipe minus --tool-call-parser minimax_m3 --enable-auto-tool-choice (gsm8k makes no tool calls). Everything else is unaffected.

openai/gpt-oss-120b (/data/models/gpt-oss-120b, MXFP4)

Server:

export HIP_VISIBLE_DEVICES=0 HSA_ENABLE_SDMA=0 USE_SVM=0 HSA_XNACK=0 HSA_COREDUMP_PATTERN=/dev/null
export VLLM_ROCM_USE_AITER=1 VLLM_ROCM_USE_SKINNY_GEMM=0 VLLM_ROCM_USE_AITER_RMSNORM=0
export VLLM_ROCM_AITER_FUSED_MOE_TRITON_GEMM_A4W4=1
vllm serve /data/models/gpt-oss-120b --host localhost --port 8000 --tensor-parallel-size 1 \
    --gpu_memory_utilization 0.7 --attention-backend TRITON_ATTN

Selected path: AITER_MXFP4_BF16 MoE backend, aiter gfx1250 grouped TDM kernel with MXFP8
activations (AITER_FORCE_A8W4=1 is set by the vLLM branch; the kernel has no bf16-activation
variant, so this is effectively W4A8).

Eval:

lm_eval --model local-completions \
  --model_args "base_url=http://localhost:8000/v1/completions,pretrained=/data/models/gpt-oss-120b,tensor_parallel_size=1,add_bos_token=true,trust_remote_code=true,max_gen_toks=2048" \
  --apply_chat_template --tasks gsm8k --num_fewshot 5 --batch_size 64
gsm8k 5-shot (1319 q) before fixes after
flexible-extract 0.0008 0.8961 ± 0.0084
strict-match 0.0000 0.2100 ± 0.0112 (harmony output rarely emits #### N)

Other models — /app/vllm_smoketest.sh (gsm8k 5-shot, limit 100, recipes verbatim from the image)

model flexible-extract strict-match
gpt-oss-120b-w-mxfp4-a-fp8 0.93 0.22
DeepSeek-R1-0528-MXFP4 0.80 0.88
DeepSeek-V4-Flash 0.96 0.96
MiniMax-M3-MXFP4 (without --tool-call-parser, see note) 0.94 0.94

oai-gpt-oss is good only after this is merged into aiter ROCm/aiter#5801

fadara01 and others added 30 commits September 20, 2026 12:25
Signed-off-by: Fadi Arafeh <fadi.arafeh@arm.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Li, Jiang <jiang1.li@intel.com>
… buffer dtype (vllm-project#57462)

Signed-off-by: Matt Mastracci <matthew@mastracci.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Co-authored-by: Lucas Wilkinson <LucasWilkinson@users.noreply.github.com>
…ws (vllm-project#57416)

Signed-off-by: Matt Mastracci <matthew@mastracci.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Liuyinfeng01 <yinfeliu@amd.com>
Co-authored-by: Shanshan Shen <467638484@qq.com>
…lm-project#57421)

Signed-off-by: mgoin <mgoin64@gmail.com>
Co-authored-by: ErinYin <liang.yin@daocloud.io>
…del (vllm-project#57708)

Signed-off-by: Mahir Dursunoglu <142054011+mahird3@users.noreply.github.com>
…er stride in the NVIDIA prefill seed kernel (vllm-project#57477)

Signed-off-by: Jared Wen <w13431838023@gmail.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…llm-project#57534)

Signed-off-by: Jared Wen <jaredwen@inferact.ai>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…load (GLM-5.3-Flash kpool tail and QSA) (vllm-project#56810)

Signed-off-by: Jared Wen <jaredwen@inferact.ai>
Signed-off-by: Jared Wen <w13431838023@gmail.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Co-authored-by: Zhewen Li <zhewenli@inferact.ai>
…dexerTopk dispatcher (vllm-project#57546)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
…lm-project#43310)

Signed-off-by: aoshen02 <aoshen@inferact.ai>
Co-authored-by: aoshen02 <aoshen@inferact.ai>
Co-authored-by: Codex <codex@openai.com>
…ject#57784)

Signed-off-by: Zyann7 <62597503+Zyann7@users.noreply.github.com>
Co-authored-by: Abatom <182586866+Abatom@users.noreply.github.com>
Signed-off-by: jinzhen.ljz <jinzhen.ljz@antgroup.com>
Signed-off-by: mgoin <mgoin64@gmail.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: mgoin <mgoin64@gmail.com>
…53945 follow-up) (vllm-project#57382)

Signed-off-by: Roi Koren <roik@nvidia.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
…-project#57450)

Signed-off-by: Sheral Kumar <shekumar@amd.com>
Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com>
Co-authored-by: Andreas Karatzas <Andreas.Karatzas@amd.com>
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Andreas Karatzas <akaratza@amd.com>
…AD mode (vllm-project#51052)

Signed-off-by: Yichao Zhu <Yichao.Zhu@amd.com>
…curacy issue. (vllm-project#57779)

Signed-off-by: yisheng <yi.sheng@intel.com>
Co-authored-by: Kunshang Ji <kunshang.ji@intel.com>
…oject#57603)

Signed-off-by: Woosuk Kwon <woosuk@inferact.ai>
Co-authored-by: Codex <noreply@openai.com>
…hrough stale block-table rows (vllm-project#56734)

Signed-off-by: Yifan Qiao <yifanqiao@inferact.ai>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
)

Signed-off-by: jiangkuaixue123 <jiangxiaozhou111@163.com>
Co-authored-by: Codex <noreply@openai.com>
…lm-project#54581)

Signed-off-by: CrazyCoder <18235787078@163.com>
Signed-off-by: aoshen02 <aoshen@inferact.ai>
Co-authored-by: aoshen02 <aoshen@inferact.ai>
Co-authored-by: Codex <noreply@openai.com>
Signed-off-by: Zhou Zihang <z@mcac.cc>
Co-authored-by: Jee Jee Li <pandaleefree@gmail.com>
…ture (vllm-project#57811)

Signed-off-by: Jee Jee Li <jeejeelee@inferact.ai>
bigPYJ1151 and others added 26 commits September 24, 2026 16:12
Signed-off-by: jiang1.li <jiang1.li@intel.com>
…ts (vllm-project#57696)

Signed-off-by: jackLei0901 <42642542+jackLei0901@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
…58275)

Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com>
Co-authored-by: OpenAI Codex <codex@openai.com>
…rdown need (vllm-project#58342)

Signed-off-by: Stefan Koncarevic <Stefan.Koncarevic@amd.com>
Signed-off-by: Andreas Karatzas <Andreas.Karatzas@amd.com>
Co-authored-by: Andreas Karatzas <Andreas.Karatzas@amd.com>
Co-authored-by: Andreas Karatzas <akaratza@amd.com>
…c value (vllm-project#54514)

Signed-off-by: Lai, Yejing <yejing.lai@intel.com>
Co-authored-by: Kunshang Ji <kunshang.ji@intel.com>
…-project#54508)

Signed-off-by: priyansh jain <priyansh.jain2@amd.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Andreas Karatzas <akaratza@amd.com>
Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>
…vllm-project#58378)

Co-authored-by: Bugen Zhao <i@bugenzhao.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: reidliu41 <reid201711@gmail.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
…ting Sentence Transformers from applying chat template (vllm-project#58117)

Signed-off-by: RyanMa29 <ziyang.ma@intel.com>
Signed-off-by: R <Ganesh.R@amd.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Li, Jiang <jiang1.li@intel.com>
…ect#57528)

Signed-off-by: Shrey Gajjar <shreygajjar007@gmail.com>
…sor (vllm-project#58460)

Signed-off-by: Zijing Liu <liuzijing2014@gmail.com>
Signed-off-by: zhenwei-intel <zhenwei.liu@intel.com>
… wo_a as a grouped FP8 GEMM (vllm-project#58456)

Signed-off-by: fai <fangzhouai@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…al tests (vllm-project#57347)

Signed-off-by: Linze-Shi <linzeshi0@gmail.com>
…ast` (vllm-project#58550)

Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: yewentao256 <zhyanwentao@126.com>
…eneration-config (vllm-project#50769)

Signed-off-by: Chenglun Hu <chenglunhu@gmail.com>
Signed-off-by: hclsys <chenglunhu@gmail.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Signed-off-by: Wauplin <lucainp@gmail.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: jpvillam <juan.villamizar@amd.com>
@JadenMathias
JadenMathias deleted the jm/oai-oss-path branch October 9, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.