Skip to content

Merge upstream GitHub workflow changes to gfx11 - #1357

Merged
eble-amd merged 2 commits into
gfx11from
eble.merge-from-upstream
Oct 8, 2026
Merged

eble-amd merged 2 commits into
gfx11from
eble.merge-from-upstream

Conversation

@eble-amd

@eble-amd eble-amd commented Oct 8, 2026 •

Copy link
Copy Markdown

Purpose

Merge "Only run GitHub Actions on the main repo" (vllm-project#55349, interesting facts there) to gfx11.

Noteworthy decisions:

  • Accept the upstream pre-run-check job definition, which will no longer run in this fork. We had previously deleted this entire job definition to keep it from running; now that is not a problem.
  • Continue allowing the pre-commit job to run in this branch. We've been getting some value out of it.
  • Accept the disablement of the proto job, which used to run checks on files in rust/proto/ when we merged changes from upstream. We're not likely to work in that area in this branch, so it doesn't seem valuable.

Validation

CI


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

hmellor and others added 2 commits September 5, 2026 00:09
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
The change is "Only run GitHub Actions on the main repo" (vllm-project#55349).
Noteworthy decisions:

- Accept the upstream `pre-run-check` job definition, which will no
  longer run in this fork.  We had previously deleted this entire job
  definition to keep it from running; now that is not a problem.
- Continue allowing the `pre-commit` job to run in this branch.
  We've been getting some value out of it.
- Accept the disablement of the `proto` job, which used to run checks on
  files in `rust/proto/` when we merged changes from upstream.  We're
  not likely to work in that area in this branch, so it doesn't seem
  valuable.

Signed-off-by: Dan Eble <Dan.Eble@amd.com>
@eble-amd
eble-amd merged commit 84486fc into gfx11 Oct 8, 2026
11 checks passed
@eble-amd
eble-amd deleted the eble.merge-from-upstream branch October 8, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants