Repository navigation
[ROCm][Perf] W4A16: opt-in dense weight cache for RDNA hybrid prefill - #1410
Merged
Merged
Conversation
roberteg16
approved these changes
Oct 28, 2026
roberteg16
left a comment
There was a problem hiding this comment.
Don't forget to update the model settings configuration! LGTM
…hybrid prefill Signed-off-by: Zohaib Moti <zohaib.moti@amd.com>
zohaibm-amd
force-pushed
the
port/prefill-dequant-cache
branch
from
October 28, 2026 13:25
e8da3b2 to
f5e24c7
Compare
eble-amd
approved these changes
Oct 28, 2026
eble-amd
left a comment
There was a problem hiding this comment.
Thanks. I believe that this leaves less work for me when I reach the point of merging your upstream contribution into gfx11.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Ports vllm-project#60710 (merged upstream as 94ad4df) to
gfx11. It replaces the gfx11-only--w4a16-prefill-dequantengine option with the upstreamKernelConfig.rdna_hybrid_w4a16_prefill_dequantoption. See vllm-project#60710 for the design, theM >= 256threshold rationale, and the performance and accuracy data.Breaking change:
--w4a16-prefill-dequantis removedThe old option and
ModelConfig.w4a16_prefill_dequantno longer exist. Passing--w4a16-prefill-dequantnow fails argument.--w4a16-prefill-dequant off(default)"disable")--w4a16-prefill-dequant hard--kernel-config '{"rdna_hybrid_w4a16_prefill_dequant": "enable"}'--w4a16-prefill-dequant softenableor leave it offThe dotted form
--kernel-config.rdna_hybrid_w4a16_prefill_dequant enablealso works. From Python, passkernel_config={"rdna_hybrid_w4a16_prefill_dequant": "enable"}. Any scripts or CI configs that pass the old option must switch to the new one before picking up this change.Behaviour differences vs the old
hardmodeM >= 256. It used to apply to everyM > 5. Batches of 6–255 tokens (including spec-decode verify) now stay on the int4 Triton kernel, where dense was no faster (see [ROCm][Perf] W4A16: opt-in dense weight cache for RDNA hybrid prefill vllm-project/vllm#60710). Performance should be the same or better.max_model_lenrequest. A config that only barely fit underhardcan now fail at startup. The error names the option. Raisegpu_memory_utilizationor lowermax_model_len.