Repository navigation
Merge upstream→gfx11 - #1413
Merged
Merged
Merge upstream→gfx11#1413
Conversation
…oject#52798) Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: HDCharles <{"message":"Not Found","documentation_url":"https://docs.github.com/rest/users/emails#list-email-addresses-for-the-authenticated-user","status":"404"}> Co-authored-by: OpenAI Codex <codex@openai.com> Co-authored-by: OpenAI Codex <noreply@openai.com>
No file conflicts.
Compressed-tensors W4A16 MoE models crash on gfx11 at the first forward pass with HSA_STATUS_ERROR_MEMORY_FAULT. A merge from upstream brought in vllm-project#52798, which makes CompressedTensorsWNA16MoEMethod always load weights N-first ([E, N, K/8], scales [E, N, K/G]), but the gfx11 hybrid W4A16 path still converted them as K-first. The hybrid path now unpacks along K without transposing before the ExLlama shuffle, and no longer transposes the scales, which already have the layout HybridW4A16MoEExperts expects. Assisted-by: LLM Signed-off-by: Dan Eble <Dan.Eble@amd.com>
eble-amd
requested review from
mgehre-amd,
roberteg16,
stoivonen-amd and
zohaibm-amd
October 28, 2026 21:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Merge c01368f from upstream and adapt local Hybrid W4A16 MoE to the new N-first weight layout.
With the upstream change alone, compressed-tensors W4A16 MoE models crashed on gfx11 at the first forward pass with
HSA_STATUS_ERROR_MEMORY_FAULT. The merge from upstream brought in vllm-project#52798, which makesCompressedTensorsWNA16MoEMethodalways load weights N-first ([E, N, K/8], scales[E, N, K/G]), but the gfx11 hybrid W4A16 path still converted them as K-first.The hybrid path now unpacks along K without transposing before the ExLlama shuffle, and no longer transposes the scales, which already have the layout
HybridW4A16MoEExpertsexpects.Assisted-by: LLM
Test Plan & Results (agentic)
gfx1151 (Strix Halo), ROCm 7.17.26431, PyTorch 2.13.0+rocm10.3.0a20261027, Triton 3.8.0.
Base:
49c3a2e2ae05(before the merge). PR: merge55a5667e9aa4with this fix.Without the fix, the merge crashes with
HSA_STATUS_ERROR_MEMORY_FAULTon the first forward pass of compressed-tensors W4A16 MoE models (e.g.cyankiwi/Qwen3-30B-A3B-Instruct-2507-AWQ-4bit). With it, all cases below pass, with identical token counts.¹ Median of 5 runs per side. This case samples at temperature 1.0, so TPOT varies with MTP acceptance length (base 1.861–1.890, PR 1.861–1.888).
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.