Skip to content

MCX A366 SLCD BSP driver support#11608

Open
yuplus wants to merge 4 commits into
RT-Thread:masterfrom
yuplus:feature/slcd_drv
Open

MCX A366 SLCD BSP driver support#11608
yuplus wants to merge 4 commits into
RT-Thread:masterfrom
yuplus:feature/slcd_drv

Conversation

@yuplus

@yuplus yuplus commented Jul 11, 2026 •
edited
Loading

Copy link
Copy Markdown

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

FRDM-MCXA366 板载段码 LCD，MCXA366 片内有 SLCD0 控制器，NXP SDK 也提供了 fsl_slcd，但本 BSP 此前未接入：引脚未配置、SDK 驱动未参与编译、缺少板级段码封装，无法在 RT-Thread 下点亮并显示数字/时间。需要补齐板级 SLCD 驱动，便于后续应用直接使用板载显示。

你的解决方案是什么 (what is your solution)

在 frdm-mcxa366 中分层接入 SLCD：

  1. 引脚：BOARD_InitSLCDPins()，将 PORT0_1227 配置为 LCD_P1631（Alt9）。
  2. SDK 驱动：将 fsl_slcd.c 加入 MCXA366 编译，负责控制器初始化、背板相位与前板波形。
  3. 板级封装：新增 board/ports/drv_slcd，基于 fsl_slcd 实现本板 6 位段码映射，提供清屏、数字/字符串、冒号与 HH:MM 时间显示等 API。
  4. 配置：在 board/Kconfig 增加 BSP_USING_SLCD，按需开启。

应用通过 rt_hw_slcd_init() / rt_hw_slcd_display_time() 等接口使用；默认配置文件（如 rtconfig.h）可不强制合入，由使用者在 menuconfig 中打开后生成。

请提供验证的bsp和config (provide the config and bsp)

  • BSP: bsp/nxp/mcx/mcxa/frdm-mcxa366
  • .config: CONFIG_BSP_USING_SLCD=y
数字显示
image cdf1110a0dad8eff42dc86c58a74f607
时间显示
image 2a16f44ab6bcc7a7e79f945f4ba15297
小数点显示
image 6b6d2c68ed442ef9667fd1828324894d

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用clang-format 源码格式化工具确保格式符合RT-Thread代码规范 This PR has been formatted with clang-format and complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@yuplus yuplus requested a review from Rbb666 as a code owner July 11, 2026 02:16
@github-actions

github-actions Bot commented Jul 11, 2026

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：feature/slcd_drv
  • 设置PR number为 \ Set the PR number to：11608
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 feature/slcd_drv 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the feature/slcd_drv branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions Bot added BSP: NXP Code related with NXP BSP labels Jul 11, 2026
@github-actions

github-actions Bot commented Jul 11, 2026 •
edited
Loading

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: bsp_mcxa

Reviewers: @hywing

Changed Files (Click to expand)
  • bsp/nxp/mcx/mcxa/frdm-mcxa366/.ci/attachconfig/ci.attachconfig.yml
  • bsp/nxp/mcx/mcxa/frdm-mcxa366/board/Kconfig
  • bsp/nxp/mcx/mcxa/frdm-mcxa366/board/MCUX_Config/board/pin_mux.c
  • bsp/nxp/mcx/mcxa/frdm-mcxa366/board/MCUX_Config/board/pin_mux.h
  • bsp/nxp/mcx/mcxa/frdm-mcxa366/board/ports/SConscript
  • bsp/nxp/mcx/mcxa/frdm-mcxa366/board/ports/drv_slcd.c
  • bsp/nxp/mcx/mcxa/frdm-mcxa366/board/ports/drv_slcd.h

📊 Current Review Status (Last Updated: 2026-07-16 15:40 CST)

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@yuplus yuplus changed the title SLCD BSP driver support MCX A366 SLCD BSP driver support Jul 11, 2026
@CLAassistant

CLAassistant commented Jul 11, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@yuplus yuplus force-pushed the feature/slcd_drv branch from 1ac6677 to 5a3c6a0 Compare July 11, 2026 02:50
@CYFS3

CYFS3 commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

还有软件包应该需要把
image
加上，麻烦软件包也提个pr吧，其他的lgtm

@CYFS3

CYFS3 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

另外可以加个ci看护起来，ci-attach
教程：https://club.rt-thread.org/ask/article/d273bbcd1f8779bc.html

@yuplus

yuplus commented Jul 16, 2026

Copy link
Copy Markdown
Author

还有软件包应该需要把 image 加上，麻烦软件包也提个pr吧，其他的lgtm

ref:
RT-Thread-packages/nxp-mcx-series#5

@yuplus

yuplus commented Jul 16, 2026

Copy link
Copy Markdown
Author

lgtm

@yuplus

yuplus commented Jul 16, 2026

Copy link
Copy Markdown
Author

另外可以加个ci看护起来，ci-attach 教程：https://club.rt-thread.org/ask/article/d273bbcd1f8779bc.html
当前默认
BSP_USING_SLCD=y
ci-attach 是否有必要？

@CYFS3

CYFS3 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

另外可以加个ci看护起来，ci-attach 教程：https://club.rt-thread.org/ask/article/d273bbcd1f8779bc.html
当前默认
BSP_USING_SLCD=y
ci-attach 是否有必要？

请把默认的关闭
image

@yuplus

yuplus commented Jul 16, 2026

Copy link
Copy Markdown
Author

lgtm

@yuplus yuplus requested a review from Rbb666 July 16, 2026 06:45
Rbb666
Rbb666 reviewed Jul 16, 2026
View reviewed changes
Comment thread bsp/nxp/mcx/mcxa/frdm-mcxa366/board/Kconfig Outdated
yuplus added 2 commits July 16, 2026 15:26
@yuplus
Update default for SLCD display configuration
7873696 
Change default setting for onboard SLCD display to 'n'.
@yuplus
Include SLCD peripheral in attachconfig.yml
9f14e2d 
Add SLCD peripheral configuration to CI attach config
@yuplus

yuplus commented Jul 16, 2026

Copy link
Copy Markdown
Author

另外可以加个ci看护起来，ci-attach 教程：https://club.rt-thread.org/ask/article/d273bbcd1f8779bc.html
当前默认
BSP_USING_SLCD=y
ci-attach 是否有必要？

请把默认的关闭
done

@yuplus yuplus requested a review from Rbb666 July 16, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rbb666 Rbb666 Awaiting requested review from Rbb666 Rbb666 is a code owner

Assignees

No one assigned

Labels

BSP: NXP Code related with NXP BSP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yuplus @CLAassistant @CYFS3 @Rbb666