ENH: Add script to install python packages locally - #978
Open
axel-grc wants to merge 1 commit into
Open
Conversation
SimonRit
approved these changes
Aug 25, 2026
SimonRit
left a comment
SimonRit
left a comment
Collaborator
There was a problem hiding this comment.
Nice, just two small questions below
| # | ||
| # All paths below can be overridden via environment variables. | ||
|
|
||
| set -euo pipefail |
Collaborator
There was a problem hiding this comment.
-eu look good. Why set -o pipefail? There is no pipe here as far as I can tell.
I would also consider adding -x
| --config-settings=cmake.define.ITK_USE_PYTHON_LIMITED_API=OFF | ||
| ) | ||
| echo "==> Installing RTK Python package (editable)" | ||
| rm -rf "$RTK_PIP_BUILD_DIR" |
Collaborator
There was a problem hiding this comment.
Should we keep the build directory to avoid recompiling from scratch for C++ changes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.