Repository navigation
Fix Monte Carlo random sampling for VRE siting availability - #249
Draft
patrickbrown4 wants to merge 22 commits into
Draft
patrickbrown4 wants to merge 22 commits into
patrickbrown4 wants to merge 22 commits into
Conversation
…n process_unitdata
patrickbrown4
marked this pull request as draft
October 7, 2026 20:09
patrickbrown4
marked this pull request as ready for review
October 7, 2026 23:23
patrickbrown4
marked this pull request as draft
October 7, 2026 23:39
…apital_adder_per_mw fixed for supply curve files in mcs_sampler.py
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR partially addresses #41 by fixing the Monte Carlo sampling functionality for VRE siting availability.
Latin hypercube sampling for VRE siting availability is still broken; we can decide whether to fix that here or in a followup PR.
Technical details
Implementation notes
Additional changes
writecapdat.py: I was having trouble following the structure while debugging, so reorganized to put the globals at the top and renamed a few variables (sorry)assign_class(); I was getting float classes (instead of integers) without this change, which were messing up downstream processing.mcs_sampler.py: We no longer need the exogenous or prescribed capacity processing, so those parts are removed along with the recf profile processing.mcs_distributions_default.yaml:Issues resolved
#41 (partially)
Known incompatibilities
MonteCarlo_LHS(latin hypercube) case when siting is included; I'm not sure why it's behaving differently fromMonteCarlo_Random. I think the fix to random sampling is valuable enough to get in on its own, but if the LHS case ends up being a quick/easy fix, we can include it here too.TODO before merge
missing_class_resource.csv)Validation, testing, and comparison report(s)
The MonteCarlo_Random case now works with VRE siting included in the distribution.
I'll include a full-US comparison once it finishes.
Checklist for author
Details to double-check
General information to guide review
Did you use LLM tools (chatbot or copilot) in the preparation of this PR? If so, describe how
No