Repository navigation
Conversation
…alled yet fisher counts a plugin as installed when its fish variables say so. When those come from another machine (fish_variables in a dotfiles repo), a new machine's first `fisher update` runs the update hook, which asked the not-yet-created virtual environment for a setting and printed 'Unknown command: .../bin/lookup_setting'. Run the install hook instead.
tsvikas
marked this pull request as ready for review
November 20, 2026 04:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When fisher's own records say fish-ai is installed but it isn't, as on a new machine whose
fish_variablescomes from a dotfiles repo, the firstfisher updateemitsfish_ai_updaterather thanfish_ai_install.The update hook then calls
$_fish_ai_install_dir/bin/lookup_settingbefore the virtual environment exists, and printsfish: Unknown command: .../bin/lookup_setting(it then goes on to create the environment).This makes the update hook run the install hook and return when
bin/lookup_settingisn't there yet, after the old directory and config moves, which may put an installation in place.Tested with
fish --no-config, sourcingconf.d/fish_ai.fishwith_fish_ai_installstubbed: with no installation directory the update calls the install hook; with one, it doesn't.Version bumped to 2.22.1 by hand (the
bump-versionhook needswhat-bump); this collides with #914, which bumps to the same version.🤖 Generated with Claude Code