[i18n] Incorrect usage of translation function

[fbausch]

The file visualization.js contains an incorrect usage of the t() function for loading translated UI strings. Therefore, it is not possible to translate the strings that are supposed to be displayed to users.

• Go to https://github.com/Rello/analytics/blob/master/js/visualization.js#L1790C1-L1790C114
• Because of the inline logic in the second parameter of the t() function, the strings Aggregation and Disaggregation are not detected and offered for translation in Transifex.

The code should roughly look like this, instead:

        return {
            label: mode === 'aggregate' ? t('analytics', '{label} Aggregation', { label: dataset.label}) : t('analytics', '{label} Disaggregation', { label: dataset.label }),
            backgroundColor: dataset.backgroundColor,
            borderColor: dataset.borderColor,
            borderDash: [5, 5],
            type: 'line',
            yAxisID: 'secondary',
            data: data,
            hidden: hidden,
            analyticsFunction: mode,
            analyticsFunctionSourceIndex: sourceIndex,
        };

[Rello]

Fixed in commit d9a916d9.

[rakekniven]

So we can close it?