Repository navigation
fix: an empty validated field inside an invisible column no longer blocks submit (6.4.x) - #250
Closed
RensTillmann wants to merge 1 commit into
Closed
RensTillmann wants to merge 1 commit into
RensTillmann wants to merge 1 commit into
Conversation
…ocks submit (6.4.x)
This was referenced Oct 20, 2026
Owner
Author
|
The fix is already released in 6.4.010 (release PR #299, merged 21 Oct 2026): src/includes/class-ajax.php line 8694 skips invisible columns in collect_required_fields(). This PR's two repo tests were not part of that release and stay on this branch. The browser suite covers this on 6.4.010 (invisible-column.spec.ts, 2 tests passed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On 6.4.0xx a form with an empty field that has a validation rule (for example numeric or email) inside a column set to invisible is rejected by the server with "Please fill in all required fields.", although the browser accepted it:
validate_formskips fields under an invisible column (has_hidden_parent()defaultsincludeInvisibleColumnsto true), but the payload still submits them andSUPER_Ajax::collect_required_fields()enrolled them as required.Fix:
collect_required_fields()skips the subtree of acolumnwhoseinvisibleistrue, matching the browser. Hidden fields and the payload JS are unchanged.Replaces the 6.4 part of closed #219 (which targeted the archived
stablebranch). LTS is not affected: itshas_hidden_parent()has no invisible-column check, so client and server already agree there.Base branch
release/6.4.x: bug fix for the beta channel (frozen: security and bug fixes only). Not needed onlts/6.3.x(see above).Tests
Changelog:
src/docs/changelog.mdgets an "Unreleased - Version 6.4.010-beta" section with one Fix line.Merge
Draft: for QA and the next 6.4.0xx release session; not merged by the author.