Skip to content

at beginning of "author and reviewer meet" section: move "sync/async" box, remove, or re-frame #68

Description

@NickleDave

from Collab22 session:
a couple comments from the Barry/David group that it's a bit distracting to start this section with an aside about sync v. async code review.

(or at least, I heard the comments that way because I also found this a bit disorienting on my read through)

Consider:

  • re-frame "code review is a process with sync + aysnc components"
  • move to the end
  • remove completely -- because this particular section focuses on a face-to-face component of our process designed specifically for researchers; could say at end something like "future reviews between this author and reviewer may move to a combination of sync/async as both become familiar with the research question + and related code"

e.g. from @lucydot (tagging people so we can hopefully give credit later)

At the beginning of the section re-frame as “code review can be split into two types: synchronous and asynchronous….” and then the box about asynchronous review (or move this box to the end of the section?).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions