Conversation
…sh controls The document pane's Document / Publish tabs become a strip of detail blocks — Applying to, Funding goal, Authors, Cover image for a proposal; Funding amount, Short description, Contacts, Cover image for an RFP — each opening a popover with just its section of the form (or, for the RFP picker, the existing modal). The strip shows as many blocks as the pane is wide enough for, in a fixed order, and folds the rest into the "All details" block, which opens the full form and says how many it holds (hooks/useFittingCount). The workspace header gains the document's title, a "N remaining" pill and a Publish button that stays disabled until nothing required is missing; a published document shows a Published pill and an Update button. The form now lives as long as the note does, so switching views no longer rehydrates it from stale content. Below the tablet breakpoint the drawer trades the strip for a Document | Details switch, with the remaining count on Details and the publish controls inline. Supporting changes: completion.ts derives what is missing from the zod schema without touching form errors; PublishStatusPill; PublishButton gains requireComplete and reads Update for published works; the funding section is split into FundingOpportunityField, FundingGoalField and a FundingGoalSection with a shared useSelectedGrant; sections take a className so they render bare in a popover; PublishingForm gains showFooter; NotebookTabs loses its labels prop and the header its "Esc to close" hint. Verified with type-check, eslint and prettier only. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Sep 22, 2026
|
This was referenced Sep 22, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The document pane's Document / Publish tabs become a strip of detail
blocks — Applying to, Funding goal, Authors, Cover image for a proposal;
Funding amount, Short description, Contacts, Cover image for an RFP —
each opening a popover with just its section of the form (or, for the
RFP picker, the existing modal). The strip shows as many blocks as the
pane is wide enough for, in a fixed order, and folds the rest into the
"All details" block, which opens the full form and says how many it
holds (hooks/useFittingCount). The workspace header gains the document's
title, a "N remaining" pill and a Publish button that stays disabled
until nothing required is missing; a published document shows a
Published pill and an Update button. The form now lives as long as the
note does, so switching views no longer rehydrates it from stale content.
Below the tablet breakpoint the drawer trades the strip for a
Document | Details switch, with the remaining count on Details and the
publish controls inline.
Supporting changes: completion.ts derives what is missing from the zod
schema without touching form errors; PublishStatusPill; PublishButton
gains requireComplete and reads Update for published works; the funding
section is split into FundingOpportunityField, FundingGoalField and a
FundingGoalSection with a shared useSelectedGrant; sections take a
className so they render bare in a popover; PublishingForm gains
showFooter; NotebookTabs loses its labels prop and the header its
"Esc to close" hint.
Verified with type-check, eslint and prettier only.
Stack
Part of turning the AI Mode overlay into a funding workspace (plan and mock decisions in the first PR's thread). Stacked on #1116; merge that first, then this one.
🤖 Generated with Claude Code