Repository navigation
Pass drawable size to cores for adaptive presentation - #35
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a window resizes, adaptive core projection needs the available drawable area before the frontend letterboxes its picture. Sample SDL drawable pixels after events and include the dimensions in every grant; minimized windows report unavailable. The measurements cover all three play paths and turbo grants.
Depends on RetroPortingToolKit/Retro-Runtime#7. Pin the published prerequisite commit
c6209ca026b99f70943504beeb8b41d6eb57cd5fso ordinary builds and CI include CoreLink 2.3 / rcore draft 9. Merge Runtime #7 first, preserving that commit or updating this pin to the resulting merged commit before merging this PR.Local build scripts now select the supplied Runtime checkout for both shared link and runner in one CMake build. This preserves the frontend's SDL/GL dependency choice and removes the redundant standalone runner build. Older Runtime source checkouts remain compilable through a feature gate; older 2.x runner binaries continue to receive the original grant prefix.
Validation: MSVC Release frontend and GL-enabled runner built and the flat title-app prefix verified. Six relevant CTests passed, including offscreen picture rendering, core settings, callback resize/unavailable/recovery, and protocol prefix decoding. A fresh default configuration using the pinned submodule resolved the new API successfully. The prerequisite Runtime passed all 32 CTests and real 2.2/2.3 compatibility checks in both directions. No binaries or machine-specific paths are included.
Related adaptive Smash stack: RetroPortingToolKit/n64lle#97 and RetroPortingToolKit/SuperSmashBrosRecomp#1. Merge Runtime #7 first, then Launcher #35 with its Runtime pin preserved or updated to the merged commit; merge n64lle #97 before the game PR. No merge or release has been performed by the agent.