Repository navigation
Agree netplay execution profiles before core init - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete execution-profile agreement before core init/guest boot instead of forcing every capable peer onto a portable backend. Rcore draft 10 appends a pre-init capability/qualification query and an agreed profile index in init params. The runner uses recomp-net's fixed offer/ACK barrier, adds the common profile plus capability transcript to existing identity, and preserves core/package/content/boot checks. Old runners/cores retain their safe startup behavior; unsupported new barriers refuse startup.
Also process final control acknowledgements before classifying BYE as a disconnect, so a coordinated clean stop is recognized when both packets arrive together. No UI or live profile/HLE/LLE switching is added.
Validation: 33 Windows static runner tests; 33 Linux static and 33 Linux loaded-module tests, including optimized/fallback pre-init agreement, changed-preparation refusal, and one-peer clean stop. Real two-process Smash cold boots retain Windows TLS+AVX2 when shared and choose portable when one peer withholds optimizations; forced rollbacks have zero desyncs and matching confirmed state. Existing netplay load-state refusal remains.
Requires recomp-net startup_profiles.h (194dafb; module ABI minor 1). Windows static netplay is validated; the pre-existing optional Unix dlfcn module loader is not newly supported on Windows.
Tracking: beads-hn9l.2.47. Consumer: n64lle 0.456.0, followed by Retro-Launcher runtime pin.