Repository navigation
Find keyboard settings beside extensionless executables - #772
Merged
Merged
Conversation
tetrisgm
pushed a commit
to tetrisgm/psxrecomp
that referenced
this pull request
Oct 27, 2026
…ix/keybinds-extensionless-exe-752 Find keyboard settings beside extensionless executables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An extensionless Linux executable path was treated as a directory, so the adjacent keybinds.ini was never loaded. Resolve an existing directory as a directory and otherwise derive the executable's parent; explicit trailing separators remain directory paths. This also handles existing directories with dots in their names.
Fixes #752. Tracking: beads-67cr.
Validation: the actual keyboard/input fixture fails on the old implementation and passes with this fix on Windows/GCC/SDL3 and Linux/cc/SDL3. Coverage includes an extensionless executable, adjacent first-run INI creation, configured W → Up input, .exe paths, dotted directories, explicit directory paths, persistence/reload, and Escape suppression. The combined Release runtime builds, and all 16 selected regression tests pass at dd9a4ad. No owner saves/settings were used.