Repository navigation
Report completed saves correctly and clear abandoned restore scopes - #773
Merged
Merged
Conversation
3 tasks
tetrisgm
added a commit
to tetrisgm/psxrecomp
that referenced
this pull request
Oct 27, 2026
Backport the restore-context portion of upstream RetroPortingToolKit#773; R4 already tracks save completion with its own status field. Co-Authored-By: GPT-6 <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The debug save-status response kept a separate pending flag after the canonical save request had completed, leaving checkpoint automation waiting indefinitely. Derive status from the canonical request. Snapshot restores also clear an abandoned dirty pump site after a longjmp skips its normal epilogue, so the next host checkpoint can proceed safely.
Publishes the two existing framework fixes from the accepted Silent Hill 1/2 and South Park checkpoint work, preserving their original commits via cherry-pick references. Repairs the resident test fixture's duplicate/missing symbols and keeps the save-status assertions enabled in Release builds.
Refs #768; this does not complete every title pin/promotion task. Tracking: beads-lqpv and beads-eio.3.414.
Validation: actual save-status/title-policy and interrupt/host-snapshot regressions pass on Windows and Linux. The combined Release runtime builds and all 16 selected CTest cases pass at dd9a4ad. Existing owner acceptance of Silent Hill 1/2 and South Park is retained, including their recorded presentation/gameplay caveats; no repeat owner playtest was launched.