Repository navigation
Preserve MCP argument boundaries - #141
Open
dajiaohuang wants to merge 2 commits into
Open
dajiaohuang wants to merge 2 commits into
dajiaohuang wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #128
Description
Keep command and arguments separate and represent arguments as a JSON string array, preserving spaces and empty strings. Reject JSON null roots and null members at this external parsing boundary using the existing JsonException user error path.
PR type
PR checklist
Validation and limits
This update publishes the previously completed local correction. Its complete normalized source files match the exact isolated candidate successfully compiled in the earlier reassessment (Desktop x64, MSIX packaging disabled, 0 warnings/0 errors), apart from the newly added dated comment notice. The earlier isolated JSON boundary component checks passed 6 cases. No tests/builds, application launch, WinUI interaction, MCP connection or model/provider/audio/image generation were run in this publication unit. Historical compilation is not current hosted CI or end-to-end acceptance. Existing notices and GPL license retained.
AI disclosure: Codex prepared this publication update under user direction to deliver already-completed work. No human review, personal certification or legal signature is claimed.