Skip to content

Dispose MCP client after failed connection #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dajiaohuang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Dispose MCP client after failed connection #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/Desktop/RodelAgent.UI/ViewModels/Items/McpServerItemViewModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ private async Task TryConnectAsync()
{
await client.DisposeAsync();
McpServers.Remove(Id);
client = null;
}

_runCts = new CancellationTokenSource();
Expand Down Expand Up @@ -109,6 +110,18 @@ private async Task TryConnectAsync()
}
catch (Exception ex)
{
if (client != null)
{
try
{
await client.DisposeAsync();
}
catch (Exception disposeException)
{
this.Get<ILogger<McpServerItemViewModel>>().LogWarning(disposeException, "Failed to dispose MCP client after connection failure.");
}
}

State = McpServerState.Error;
FunctionCount = 0;
Functions.Clear();
Expand Down Expand Up @@ -176,4 +189,4 @@ public sealed class McpAgentConfig : McpServerDefinition
public bool? IsEnabled { get; set; }
}

public sealed partial class McpAgentConfigCollection : Dictionary<string, McpAgentConfig>;
public sealed partial class McpAgentConfigCollection : Dictionary<string, McpAgentConfig>;