fix(ci): make the darwin DMG edge leak-proof (RIG-3335) - #1074
Merged
Conversation
The darwin lane intermittently failed at `hdiutil create` with "Resource busy", taking the rollup red on unrelated PRs and ejecting an approved fix from the merge queue. A stale attachment left by an earlier job on a reused runner makes the create's source busy. The mount was released on the happy path only, so an abort between attach and verify skipped the detach and leaked the device along with its diskimages-help process. Release the mount from an EXIT trap so any exit path detaches, and force-detach a prior run's Compass attachment before attaching. The bundle tool does the same before create, via a pure plist parser that selects only our own image path or volume so an unrelated volume is never touched. No retry: a retry would hide the leak, and the leak is the bug. Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
😎 Merged successfully - details. |
rigel-mintaka
marked this pull request as ready for review
September 11, 2026 15:27
|
Compass engineering docs preview: https://compass-native-rig-3335-hdiu.compass-eng-docs.pages.dev Deployed from |
mattwilkinsonn
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The darwin lane intermittently failed at
hdiutil createwith "Resourcebusy", taking the rollup red on unrelated PRs and ejecting an approved fix
from the merge queue.
A stale attachment left by an earlier job on a reused runner makes the
create's source busy. The mount was released on the happy path only, so an
abort between attach and verify skipped the detach and leaked the device
along with its diskimages-help process.
Release the mount from an EXIT trap so any exit path detaches, and
force-detach a prior run's Compass attachment before attaching. The bundle
tool does the same before create, via a pure plist parser that selects only
our own image path or volume so an unrelated volume is never touched.
No retry: a retry would hide the leak, and the leak is the bug.
Co-authored-by: Matt Wilkinson matt@rigel.build