Skip to content

test(comms): deepen supervisor orchestration coverage (RIG-3533) - #1114

Merged
trunk-io[bot] merged 1 commit into
mainfrom
compass-comms/rig3533-orchestration-depth
Sep 12, 2026
Merged

test(comms): deepen supervisor orchestration coverage (RIG-3533)#1114
trunk-io[bot] merged 1 commit into
mainfrom
compass-comms/rig3533-orchestration-depth

Conversation

@rigel-mintaka

@rigel-mintaka rigel-mintaka commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

This PR is part of a stack containing 4 PRs:

  1. main
  2. "test(comms): deepen supervisor orchestration coverage (RIG-3533)" (this PR)
  3. test(comms): pin the ring-lag resync arms and replay-boundary exactness (RIG-3538) #1123
  4. test(comms): pin dmChannelName properties and DM two-party read scope (RIG-3535) #1136
  5. test(comms): pin roster presence states, nil-source default, visibility clip (RIG-3537) #1137

The orchestration file held one case: a supervisor assigning to two
workers. Three contracts around it were unasserted, so a regression in any
of them would have landed green.

Per-topic thread isolation posts four workers' assignments interleaved
across topics rather than grouped, because grouped posts read back
correctly even when topic scoping is broken. Upward reports pin the author
to the worker, not the supervisor or the owner. The membership-scoped audit
asserts an outsider gets exactly zero hits, which is the no-existence-oracle
contract rather than a cosmetic count.

Each case was verified by mutating production and watching it fail: drop
the ListMessages topic filter, credit a different valid channel member as
author, and widen the search membership join past the caller. The audit
case is mutated in the leak direction specifically, since a mutation that
returns nothing exercises the positive assertion instead of the negative.

The record's fourth case, reparent reflected in coordination membership, is
deliberately omitted: TestReparentInEmitsMembershipMove already drives the
identical setup and the same both-halves membership assertions, and also
asserts the removed_account_ids event, so it is strictly stronger.

Co-authored-by: Matt Wilkinson matt@rigel.build

The orchestration file held one case: a supervisor assigning to two
workers. Three contracts around it were unasserted, so a regression in any
of them would have landed green.

Per-topic thread isolation posts four workers' assignments interleaved
across topics rather than grouped, because grouped posts read back
correctly even when topic scoping is broken. Upward reports pin the author
to the worker, not the supervisor or the owner. The membership-scoped audit
asserts an outsider gets exactly zero hits, which is the no-existence-oracle
contract rather than a cosmetic count.

Each case was verified by mutating production and watching it fail: drop
the ListMessages topic filter, credit a different valid channel member as
author, and widen the search membership join past the caller. The audit
case is mutated in the leak direction specifically, since a mutation that
returns nothing exercises the positive assertion instead of the negative.

The record's fourth case, reparent reflected in coordination membership, is
deliberately omitted: TestReparentInEmitsMembershipMove already drives the
identical setup and the same both-halves membership assertions, and also
asserts the removed_account_ids event, so it is strictly stronger.

Co-authored-by: Matt Wilkinson <matt@rigel.build>
@linear-code

linear-code Bot commented Sep 11, 2026

Copy link
Copy Markdown

RIG-3533

@trunk-io

trunk-io Bot commented Sep 11, 2026

Copy link
Copy Markdown

😎 This pull request was merged.

@rigel-mintaka
rigel-mintaka marked this pull request as ready for review September 11, 2026 20:24
@github-actions

Copy link
Copy Markdown

Compass engineering docs preview: https://compass-comms-rig3533-orches.compass-eng-docs.pages.dev

Deployed from compass-comms/rig3533-orchestration-depth at f23ccec.

@trunk-io
trunk-io Bot merged commit 05019a8 into main Sep 12, 2026
16 checks passed
@trunk-io
trunk-io Bot deleted the compass-comms/rig3533-orchestration-depth branch September 12, 2026 13:39
@trunk-io

trunk-io Bot commented Sep 12, 2026

Copy link
Copy Markdown

This pull request was merged into main as part of stacked PR 1137.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants